Closed Bug 145969 Opened 22 years ago Closed 22 years ago

Can't persist open state of content view trees

Categories

(Core :: XUL, defect)

x86
Windows 95
defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: hewitt)

Details

(Keywords: polish)

Attachments

(1 file, 1 obsolete file)

Because nsTreeContentView::ToggleOpenState removes the "open" attribute it won't
persist properly.
Attached patch Proposed patch (obsolete) — Splinter Review
Keywords: patch, polish, review
r=varga on 
-      row->mContent->UnsetAttr(kNameSpaceID_None, nsXULAtoms::open, PR_TRUE);
+      row->mContent->SetAttr(kNameSpaceID_None, nsXULAtoms::open,
NS_LITERAL_STRING("false"), PR_TRUE);
Attached patch Proposed patchSplinter Review
Oops, I'm suffering from multiple patch syndrome again :-(
Attachment #84434 - Attachment is obsolete: true
Comment on attachment 84440 [details] [diff] [review]
Proposed patch

r=varga
It would be nice to add a comment why we need to do that this way.
Attachment #84440 - Flags: review+
Jan, be sure to do that when you check it in for me :-)
Comment on attachment 84440 [details] [diff] [review]
Proposed patch

sr=jag
Attachment #84440 - Flags: superreview+
checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: