1459748 - Fork M-C's RDF service since it's going to be removed in bug 833098

Status: RESOLVED FIXED

(MailNews Core :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Sadly we won't complete work on bug 453908, bug 457333 and bug 732106 quickly enough (also see meta-bug 420506), before RDF is going to be removed in bug 833098.

So I'll fork to code here.

Comment 1

[Jorg K (CEST = GMT+2)]

Attachment: 1459748-rdf.patch

This just copies M-C rdf directory to M-C, but without the tests. I don't think we intend to modify any RDF code, so I think we can live without the tests.

This will go next to db (Mork) and mailnews. Compilation is triggered via mailnews/mailnews.mozbuild which also gets db (Mork) done.

Right now, it doesn't compile since all those interfaces are still defined in M-C.

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1459748-rdf-build.patch

Instead of attaching 400KB patches, here are some additional changes to get it to build.

Comment 3

[Jorg K (CEST = GMT+2)]

Looks like these two patches together give a working build with part 2 from bug 833098 applied.

So I'll land that when the time comes.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/13e2fda05aa3
Fork RDF to comm-central. rs=bustage-fix

Comment 5

[Jorg K (CEST = GMT+2)]

That's both patches folded.

Comment 6

[Jorg K (CEST = GMT+2)]

Attachment: 1459748-NS_PRECONDITION-rdf.patch

A few NS_PRECONDITIONs have come back in the forked code, let's kill them now.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0719cec3b020
Follow-up: Replace NS_PRECONDITION with NS_ASSERTION after removal in bug 1457813. rs=bustage-fix DONTBUILD

Comment 8

[:aceman]

Comment on attachment 8973859 [details] [diff] [review]
1459748-rdf.patch

Review of attachment 8973859 [details] [diff] [review]:
-----------------------------------------------------------------

What a large blob ;)
We should fix the referenced bugs so that this is only temporarily needed for a few days.

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: 1459748-TC-config.patch

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/02f531f15649
Follow-up: add comm/rdf to TaskCluster configuration. r=me