1459759 - Update settings when content module has registered

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Description

[Eugen Sawin [:esawin]]

Initial module settings are no longer propagated to frame scripts.

Comment 1

[Eugen Sawin [:esawin]]

Attachment: 0001-Bug-1459759-1.0-Send-settings-to-content-modules-on-.patch

We have to send the initial settings to content modules on registration. Currently, initialization settings are never set in content modules.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8973864 [details] [diff] [review]
0001-Bug-1459759-1.0-Send-settings-to-content-modules-on-.patch

Review of attachment 8973864 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/modules/geckoview/GeckoViewModule.jsm
@@ +79,5 @@
>          }
>          self.messageManager.removeMessageListener("GeckoView:ContentRegistered",
>                                                    listener);
> +        self.messageManager.sendAsyncMessage("GeckoView:UpdateSettings",
> +                                             self.settings);

This is okay, though "GeckoView:UpdateSettings" will be handled by every module that's currently loaded. We should fix that in the future.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44fb2f695bd7
[1.0] Send settings to content modules on registration. r=jchen

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/44fb2f695bd7