1459831 - Switch off buildbot builds on comm-beta

Status: RESOLVED INVALID

(Thunderbird :: Build Config, enhancement)

Description

[Jorg K (CEST = GMT+2)]

+++ This bug was initially created as a clone of Bug #1447781 +++

Now that Thunderbird 61 is at beta, we need to disable buildbot builds on the C-B tree. The patch should be very similar to bug 1447781 - layman's opinion ;-)

Comment 1

[Phabricator Automation]

Attachment: Bug 1459831 - Switch off buildbot builds on comm-beta. r=rail

This patch is form-for-function identical to https://reviewboard.mozilla.org/r/229980/diff/3

Comment 2

[Phabricator Automation]

Comment on attachment 8973991 [details]
Bug 1459831 - Switch off buildbot builds on comm-beta. r=rail

Rail Aliiev [:rail] ⌚️ET has approved the revision.

https://phabricator.services.mozilla.com/D1209

Comment 3

[Justin Wood (:Callek)]

https://hg.mozilla.org/build/buildbot-configs/rev/99bed33022737a0ad6373fa863943822be1f6d73
https://hg.mozilla.org/build/buildbot-configs/rev/acc9613422bf4656b01932efb7fd3b445acc8c42

Should get automatically deployed in ~ the next hour.

Comment 4

[Justin Wood (:Callek)]

This patch got backed out for

2018-05-09 08:21:03-0700 [-] Unhandled Error
            Traceback (most recent call last):
              File "/builds/buildbot/build1/lib/python2.7/site-packages/twisted/scripts/_twistd_unix.py", line 317, in startApplication
                app.startApplication(application, not self.config['no_save'])
              File "/builds/buildbot/build1/lib/python2.7/site-packages/twisted/application/app.py", line 648, in startApplication
                service.IService(application).startService()
              File "/builds/buildbot/build1/lib/python2.7/site-packages/twisted/application/service.py", line 278, in startService
                service.startService()
              File "/builds/buildbot/build1/lib/python2.7/site-packages/buildbot-0.8.2_hg_8b87b4974e3c_production_0.8-py2.7.egg/buildbot/master.py", line 595, in startService
                self.loadTheConfigFile()
            --- <exception caught here> ---
              File "/builds/buildbot/build1/lib/python2.7/site-packages/buildbot-0.8.2_hg_8b87b4974e3c_production_0.8-py2.7.egg/buildbot/master.py", line 628, in loadTheConfigFile
                d = self.loadConfig(f)
              File "/builds/buildbot/build1/lib/python2.7/site-packages/buildbot-0.8.2_hg_8b87b4974e3c_production_0.8-py2.7.egg/buildbot/master.py", line 652, in loadConfig
                exec f in localDict
              File "/builds/buildbot/build1/master/master.cfg", line 154, in <module>
                secrets=getattr(passwords, 'secrets', None)
              File "/builds/buildbot/build1/lib/python2.7/site-packages/buildbotcustom/process/release.py", line 350, in generateReleaseBranchObjects
                if use_mock('linux'):
              File "/builds/buildbot/build1/lib/python2.7/site-packages/buildbotcustom/process/release.py", line 312, in use_mock
                pf = branchConfig['platforms'][platform]
            exceptions.KeyError: 'linux' 

Tom is TB expecting to release using buildbot at all for beta61?

Comment 5

[Jorg K (CEST = GMT+2)]

(In reply to Justin Wood (:Callek) from comment #4)
> Tom is TB expecting to release using buildbot at all for beta61?
No. Tom even wants to start using TC for a late TB 60 beta 7.

Comment 6

[Phabricator Automation]

Attachment: Bug 1459831 - Switch off buildbot builds on comm-beta. r=rail

Different approach, just kill the schedulers.

Comment 7

[Phabricator Automation]

Comment on attachment 8974761 [details]
Bug 1459831 - Switch off buildbot builds on comm-beta. r=rail

Rail Aliiev [:rail] ⌚️ET has approved the revision.

https://phabricator.services.mozilla.com/D1257

Comment 8

[Justin Wood (:Callek)]

https://hg.mozilla.org/build/buildbot-configs/rev/ea30fb096227496bca2a8b5d9d6d6c5040e3f951
https://hg.mozilla.org/build/buildbot-configs/rev/1b2b6aef99a74890a16f18e084ade7abc602c1d9

Comment 9

[Justin Wood (:Callek)]

and as a test: https://hg.mozilla.org/releases/comm-beta/rev/f547d644566dd2abbc69987bda1129b2b6dcfbc2

Comment 10

[Justin Wood (:Callek)]

This landed, and seems to have disabled buildbot, but seems the Decision task on comm-beta is busted, and I'm not sure what the fix is...

Comment 11

[Jorg K (CEST = GMT+2)]

Hmm, looks like after the last branch date, buildbot builds have returned to comm-beta, and they are all failing.

Do these numbers get updated:
https://hg.mozilla.org/build/buildbot-configs/rev/ea30fb096227496bca2a8b5d9d6d6c5040e3f951#l1.12

Comment 12

[Justin Wood (:Callek)]

(In reply to Jorg K (GMT+2) from comment #11)
> Hmm, looks like after the last branch date, buildbot builds have returned to
> comm-beta, and they are all failing.
> 
> Do these numbers get updated:
> https://hg.mozilla.org/build/buildbot-configs/rev/
> ea30fb096227496bca2a8b5d9d6d6c5040e3f951#l1.12

I can't imagine how this could be, I'm redirecting n-i to tom and to rail atm, they may have some insight I don't.

Comment 13

[Rail Aliiev [:rail]]

config.py logic is a beast... Maybe just remove those branches from https://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/thunderbird_config.py#l626?

Comment 14

[Tom Prince [:tomprince]]

Attachment: Bug 1459831: Disable comm-beta builds.

Comment 15

[Tom Prince [:tomprince]]

Attachment: Bug 1459831: Remove comm-beta from list of thunderbird release branches; r?nthomas

Comment 16

[Phabricator Automation]

Comment on attachment 8989824 [details]
Bug 1459831: Remove comm-beta from list of thunderbird release branches; r?nthomas

Nick Thomas [:nthomas] (UTC+12) has approved the revision.

https://phabricator.services.mozilla.com/D1958

Comment 17

[Phabricator Automation]

Comment on attachment 8989823 [details]
Bug 1459831: Disable comm-beta builds.

Nick Thomas [:nthomas] (UTC+12) has approved the revision.

https://phabricator.services.mozilla.com/D1957

Comment 18

[Rob Lemley [:rjl]]

Build bot was decommissioned, and this is no longer relevant.