1459940 - Spidermonkey bustage and Jit test failures in memory-bulk.js when Gecko 62 merges to Beta on 2018-06-14

Status: VERIFIED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

[Tracking Requested - why for this release]:

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ef453ac10bd4fd18b6101bddd4e728c18a6a9e6&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=177464355

This got added in bug 1446930.

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=177464355&repo=try
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/memory-bulk.js | /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/memory-bulk.js:16:64 SyntaxError: wasm text error: parsing wasm text at 4:11 (code 3, args "") [0.2 s]
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/memory-bulk.js | /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/memory-bulk.js:16:64 SyntaxError: wasm text error: parsing wasm text at 4:11 (code 3, args "--no-wasm-ion") [0.2 s]
TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/wasm/memory-bulk.js | /builds/worker/workspace/build/src/js/src/jit-test/tests/wasm/memory-bulk.js:16:64 SyntaxError: wasm text error: parsing wasm text at 4:11 (code 3, args "--test-wasm-await-tier2") [0.2 s]

ENABLE_WASM_BULKMEM_OPS is onöy set for Nightly https://hg.mozilla.org/mozilla-central/rev/bb402086c764#l2.9
So this shouldn't be triggered to run for beta simulations.

Comment 1

[Natalia Csoregi [:nataliaCs]]

Fail occurring on Jit tests as well: https://treeherder.mozilla.org/logviewer.html#?job_id=177884834&repo=try&lineNumber=13759

[task 2018-05-10T15:46:56.595Z] 15:46:56     INFO -  Stack:
[task 2018-05-10T15:46:56.596Z] 15:46:56     INFO -    @/builds/worker/workspace/build/tests/jit-test/jit-test/tests/wasm/memory-bulk.js:16:64
[task 2018-05-10T15:46:56.596Z] 15:46:56     INFO -  Exit code: 3
[task 2018-05-10T15:46:56.596Z] 15:46:56     INFO -  FAIL - wasm/memory-bulk.js
[task 2018-05-10T15:46:56.597Z] 15:46:56  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/wasm/memory-bulk.js | /builds/worker/workspace/build/tests/jit-test/jit-test/tests/wasm/memory-bulk.js:16:64 SyntaxError: wasm text error: parsing wasm text at 4:11 (code 3, args "") [0.1 s]
[task 2018-05-10T15:46:56.597Z] 15:46:56     INFO -  {"action": "test_start", "pid": 957, "source": "jittests", "test": "wasm/memory-bulk.js", "thread": "main", "time": 1525967216.532876}
[task 2018-05-10T15:46:56.598Z] 15:46:56     INFO -  {"action": "test_end", "extra": {"jitflags": ""}, "message": "/builds/worker/workspace/build/tests/jit-test/jit-test/tests/wasm/memory-bulk.js:16:64 SyntaxError: wasm text error: parsing wasm text at 4:11", "pid": 957, "source": "jittests", "status": "FAIL", "test": "wasm/memory-bulk.js", "thread": "main", "time": 1525967216.591327}
[task 2018-05-10T15:46:56.598Z] 15:46:56     INFO -  INFO exit-status     : 3
[task 2018-05-10T15:46:56.599Z] 15:46:56     INFO -  INFO timed-out       : False
[task 2018-05-10T15:46:56.600Z] 15:46:56     INFO -  INFO stderr         2> /builds/worker/workspace/build/tests/jit-test/jit-test/tests/wasm/memory-bulk.js:16:64 SyntaxError: wasm text error: parsing wasm text at 4:11
[task 2018-05-10T15:46:56.601Z] 15:46:56     INFO -  INFO stderr         2> Stack:
[task 2018-05-10T15:46:56.602Z] 15:46:56     INFO -  INFO stderr         2> @/builds/worker/workspace/build/tests/jit-test/jit-test/tests/wasm/memory-bulk.js:16:64
[task 2018-05-10T15:46:56.639Z] 15:46:56     INFO -  /builds/worker/workspace/build/tests/jit-test/jit-test/tests/wasm/memory-bulk.js:16:64 SyntaxError: wasm text error: parsing wasm text at 4:11
[task 2018-05-10T15:46:56.639Z] 15:46:56     INFO -  Stack:
[task 2018-05-10T15:46:56.643Z] 15:46:56     INFO -    @/builds/worker/workspace/build/tests/jit-test/jit-test/tests/wasm/memory-bulk.js:16:64
[task 2018-05-10T15:46:56.643Z] 15:46:56     INFO -  Exit code: 3
[task 2018-05-10T15:46:56.643Z] 15:46:56     INFO -  FAIL - wasm/memory-bulk.js
[task 2018-05-10T15:46:56.644Z] 15:46:56  WARNING -  TEST-UNEXPECTED-FAIL | tests/jit-test/jit-test/tests/wasm/memory-bulk.js | /builds/worker/workspace/build/tests/jit-test/jit-test/tests/wasm/memory-bulk.js:16:64 SyntaxError: wasm text error: parsing wasm text at 4:11 (code 3, args "--ion-eager --ion-offthread-compile=off") [0.1 s]

Comment 2

[Julian Seward [:jseward]]

Attachment: bug1459940-test-guards-1.diff

A possible fix, cargo-culted from how other tests for other
experimental wasm features are gated.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Comment on attachment 8974966 [details] [diff] [review]
bug1459940-test-guards-1.diff

Review of attachment 8974966 [details] [diff] [review]:
-----------------------------------------------------------------

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5247f82183a6f1008ad1b54bd7b0f85bf2c2bb7c&selectedJob=178051985
The SM(f) failed before and passes now. The same can be expected for the other test suites.

Comment 4

[Julian Seward [:jseward]]

Attachment: bug1459940-test-guards-2.diff

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98b2e9629ed4
Spidermonkey bustage and Jit test failures in memory-bulk.js when Gecko 62 merges to Beta on 2018-06-14.  r=luke.

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out changeset for Spidermonkey bustages on non262/Array/from_errors.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=98b2e9629ed4b831876b66299d59d4ef85e2b406&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&filter-searchStr=1397b268fdf80daaff863bdd4befc86c7bf660df&selectedJob=178167471

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=178167471&repo=mozilla-inbound&lineNumber=58653

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/90f579626dd794ca3d235135d6f21bed5791f221

Comment 7

[Tom S. (please needinfo tschuster)]

This is actually a failure introduced by bug 1460381. The last patch in that bug will with this assertion. So this patch can be relanded.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb01c58cc0b4
Spidermonkey bustage and Jit test failures in memory-bulk.js when Gecko 62 merges to Beta on 2018-06-14.  r=luke.

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/eb01c58cc0b4

Comment 10

[Intermittent Failures Robot]

72 failures in 660 pushes (0.109 failures/push) were associated with this bug in the last 7 days. 

This is the #13 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **  

Repository breakdown:
* try: 72

Platform breakdown:
* linux64: 22
* osx-10-10: 8
* linux32: 8
* windows10-64: 5
* windows7-32: 4
* linux64-qr: 4
* windows7-32-nightly: 2
* windows7-32-devedition: 2
* windows10-64-nightly: 2
* windows10-64-devedition: 2
* macosx64-nightly: 2
* macosx64-devedition: 2
* linux64-nightly: 2
* linux64-devedition: 2
* linux32-nightly: 2
* linux32-devedition: 2
* windows2012-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1459940&startday=2018-05-07&endday=2018-05-13&tree=trunk

Comment 11

[Stefan Hindli [:stefan_hindli]]

It's fixed in today's central as beta simulation - https://treeherder.mozilla.org/#/jobs?repo=try&revision=218bf7a9b3a25071e68a7c008f6fd2761fb1e235&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable