1459946 - Add option to stop a service worker already running

Status: NEW

(DevTools :: Application Panel, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Similarly to the "start" link currently available for non-running service workers, we should also have a "stop" link for running service workers.

Comment 1

[Patrick Brosset <:pbro>]

Copying here a comment from Julian on what needs to be done to surface a stop functionality on the platform:

I think we would need to expose TerminateWorker defined at https://searchfox.org/mozilla-central/rev/55aa17110091deef24b913d033ccaf58f9c6d337/dom/serviceworkers/ServiceWorkerPrivate.cpp#1790 all the way through ServiceWorkerPrivate -> ServiceWorkerInfo -> ServiceWorkerInfo IDL ... and then we would be able to call it from the service-worker-registration actor's activeWorker
the following patch seems to work: https://hg.mozilla.org/try/rev/5fb7dea5a6017d58fa0a440030356827303f3fbe

Comment 2

[:Harald Kirschner :digitarald]

Perry, we wanted to move this forward for 78/79. Do you agree with :jdescottes approach to terminate running workers: https://hg.mozilla.org/try/rev/5fb7dea5a6017d58fa0a440030356827303f3fbe .

Comment 3

[Perry Jiang [:perry] [no longer employee, use ni?]]

Yeah, jdescottes' change looks good to me.