Closed
Bug 1459954
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10897 - [LayoutNG] Avoid false positives for clearance.
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10897 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10897 Details from upstream follow. Morten Stenshorne <mstensho@chromium.org> wrote: > [LayoutNG] Avoid false positives for clearance. > > Clearance inhibits margin collapsing and thus makes it possible to > resolve the BFC offset of its parent. In that regard we sometimes > incorrectly assumed that a child would get clearance. The only case > where we can tell for sure up front, is when there are adjoining floats > that match the value of the 'clear' property. In all other cases, we > first need to calculate the block-start border edge of the child. > > Added a few new tests. Only two of them failed in NG prior to this CL, > but coverage seemed low, so I added them anyway. Two of them fail in the > legacy engine. > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I73b4aa02e5e88d1063f345db271cde1ad31ea9f5 > Reviewed-on: https://chromium-review.googlesource.com/1049974 > WPT-Export-Revision: 629eb07dc6edb00a17a93cff10c0c1311401c4f9
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=55ae9e374bc0a338e8ce22805405766c5335fb53
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8960abfc77bedb4826cc03e072e8e2622ed40985
Reporter | ||
Comment 3•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=858297f5ac1ffd21c5eeb232d1604c3fccf91969
Reporter | ||
Comment 4•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=de0d5e2fa1c4873ef4dcd2ba7632b151de8af3f5
Reporter | ||
Comment 5•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f853695714a23602954614871dc79af4deaf668
Reporter | ||
Comment 6•6 years ago
|
||
Ran 8 tests PASS : 8
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/59355c389c24 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/59355c389c24
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•