Closed Bug 1459954 Opened 8 years ago Closed 8 years ago

[wpt-sync] Sync PR 10897 - [LayoutNG] Avoid false positives for clearance.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10897 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10897 Details from upstream follow. Morten Stenshorne <mstensho@chromium.org> wrote: > [LayoutNG] Avoid false positives for clearance. > > Clearance inhibits margin collapsing and thus makes it possible to > resolve the BFC offset of its parent. In that regard we sometimes > incorrectly assumed that a child would get clearance. The only case > where we can tell for sure up front, is when there are adjoining floats > that match the value of the 'clear' property. In all other cases, we > first need to calculate the block-start border edge of the child. > > Added a few new tests. Only two of them failed in NG prior to this CL, > but coverage seemed low, so I added them anyway. Two of them fail in the > legacy engine. > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Change-Id: I73b4aa02e5e88d1063f345db271cde1ad31ea9f5 > Reviewed-on: https://chromium-review.googlesource.com/1049974 > WPT-Export-Revision: 629eb07dc6edb00a17a93cff10c0c1311401c4f9
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/59355c389c24 [wpt PR 10897] - [LayoutNG] Avoid false positives for clearance., a=testonly
https://hg.mozilla.org/mozilla-central/rev/59355c389c24
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.