Closed
Bug 1459993
Opened 6 years ago
Closed 6 years ago
remove MSVC 2015 bits from toolchain.configure
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
4.35 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
It's unsupported, so we might as well get rid of the bits for it.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8974096 -
Flags: review?(core-build-config-reviews)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8974096 [details] [diff] [review] remove MSVC 2015 bits from toolchain.configure Review of attachment 8974096 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/moz.configure/toolchain.configure @@ +560,5 @@ > '-format', > 'json' > ] + args).decode(encoding, 'replace')) > > + # VS2017 and newer. This comment is a little abstract now. :) I'd say either reword it or just remove it now that it's no longer trying to describe the two separate invocations.
Attachment #8974096 -
Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ed0bdeaa6fd4 remove MSVC 2015 bits from toolchain.configure; r=ted.mielczarek
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ed0bdeaa6fd4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•