Closed
Bug 1460016
Opened 8 years ago
Closed 8 years ago
Update azure-entities / azure-blob-storage to support rootUrl
Categories
(Taskcluster :: Services, enhancement)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
Details
In fact, I want to go one step further and not have any relation to taskcluster in these libraries. Instead:
libAzure = require('taskcluster-lib-azure');
MyEntity.setup({
...,
credentials: libAzure.azureCredentials({
rootUrl: ..,
clientId,
accessToken,
});
});
So the change to azure-entities / azure-blob-storage is to allow an async function as the value of `credentials`, expecting it to return accountName/accountKey. Then tc-lib-azure provides a nice way to build such functions (it's a teeny thing).
Comment 1•8 years ago
|
||
Commits pushed to master at https://github.com/taskcluster/azure-entities
https://github.com/taskcluster/azure-entities/commit/870a1b4e0e4e65fdd59c923ec57b2839467e39c5
Bug 1460016 [BREAKING] remove taskcluster-specificity, change credentials format
Breaking changes:
- `account` is no longer an option to setup()
- the `table` option to setup is now called `tableName`
- Taskcluster credentials are no longer accepted, nor `authBaseUrl`
- non-test credentials now match fast-azure-storage:
- "raw" azure credentials are now given with properties 'accountId' and
'accessKey',
- sas credentials are given with properties `accountId`, `sas`, and
(when sas is a function) `minSASAuthExpiry`
- in-memory tests are now configured with `{credentials: 'inMemory'}`
https://github.com/taskcluster/azure-entities/commit/aa84b9571ec444c6ad305c5fb60a5ac2ef5f0e1d
Merge pull request #39 from taskcluster/bug1460016
Bug 1460016 - [BREAKING] remove taskcluster-specificity, change creds
| Assignee | ||
Comment 2•8 years ago
|
||
OK, that is landed for both azure-entities and azure-blob-storage, at version 4.0.0 and 3.0.0 respectively.
Taskcluster-lib-azure 10.0.0 provides the sasCredentials function needed to use that new functionality.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Component: Redeployability → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•