1460045 - Race condition when enabling modules on startup

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

For modules that are enabled when the session is opened, we don't really enable the modules until queued events are flushed _after_ the session is opened, leading to a race condition.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1460045 - Pass module enabled states through init-data;

During session initialization, pass in the enabled state of all modules
through the init-data, and use that to enable modules if necessary. This
avoids a race condition where we enable modules too late on startup due
to event queuing.

Review commit: https://reviewboard.mozilla.org/r/242466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242466/

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8974174 [details]
Bug 1460045 - Pass module enabled states through init-data;

https://reviewboard.mozilla.org/r/242466/#review248568

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8974174 [details]
Bug 1460045 - Pass module enabled states through init-data;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242466/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee5826757c45
Pass module enabled states through init-data; r=esawin

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ee5826757c45