1460046 - Make child modules behave the same way as parent modules

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Bug 1458327 introduced "GeckoView:UpdateModuleState" for parent modules. We should do the same thing for child modules.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Bug 1460046 - Make child modules behave the same way as parent modules;

Update content modules to use the "GeckoView:UpdateModuleState" message
instead of "GeckoView:Register"/"GeckoView:Unregister", similar to what
we already do for parent modules. Also only call onSettingsUpdate in
content module when the module is enabled, similar to what we already do
for parent modules.

Review commit: https://reviewboard.mozilla.org/r/242470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/242470/

Comment 2

[Eugen Sawin [:esawin]]

Comment on attachment 8974175 [details]
Bug 1460046 - Make child modules behave the same way as parent modules;

https://reviewboard.mozilla.org/r/242470/#review248572

::: mobile/android/modules/geckoview/GeckoViewContentModule.jsm:67
(Diff revision 1)
> +
> +        if (settings) {
> +          Object.assign(this.settings, settings);
> -      }
> +        }
> -    );
> -    this.messageManager.addMessageListener(
> +
> +        if (enabled !== this.enabled) {

Maybe just early return instead to reduce nesting.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8974175 [details]
Bug 1460046 - Make child modules behave the same way as parent modules;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/242470/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/59e522b59f9a
Make child modules behave the same way as parent modules; r=esawin

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/59e522b59f9a