Closed Bug 1460046 Opened 3 years ago Closed 3 years ago

Make child modules behave the same way as parent modules

Categories

(GeckoView :: General, enhancement, P3)

All
Android
enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

Bug 1458327 introduced "GeckoView:UpdateModuleState" for parent modules. We should do the same thing for child modules.
Priority: -- → P3
Comment on attachment 8974175 [details]
Bug 1460046 - Make child modules behave the same way as parent modules;

https://reviewboard.mozilla.org/r/242470/#review248572

::: mobile/android/modules/geckoview/GeckoViewContentModule.jsm:67
(Diff revision 1)
> +
> +        if (settings) {
> +          Object.assign(this.settings, settings);
> -      }
> +        }
> -    );
> -    this.messageManager.addMessageListener(
> +
> +        if (enabled !== this.enabled) {

Maybe just early return instead to reduce nesting.
Attachment #8974175 - Flags: review?(esawin) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/59e522b59f9a
Make child modules behave the same way as parent modules; r=esawin
https://hg.mozilla.org/mozilla-central/rev/59e522b59f9a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 62 → mozilla62
You need to log in before you can comment on or make changes to this bug.