Closed Bug 1460119 Opened 2 years ago Closed 2 years ago

gSnippetsMap.getTotalBookmarksCount() never resolves

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 62
Iteration:
62.1 - May 21
Tracking Status
firefox61 + fixed
firefox62 + fixed

People

(Reporter: rrosario, Assigned: rrosario)

References

Details

User Story

https://github.com/mozilla/activity-stream/compare/66b23ff4695a0edd97dda9db0efa62138b001d56...firefox-61b5

Attachments

(2 files)

Assignee: nobody → rrosario
Iteration: --- → 62.1 - May 21
Priority: -- → P1
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/71ff8f317d16f48747f3ef321854616c1981d286
Fix Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves (#4145)

* Fix Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

* undo change
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
[Tracking Requested - why for this release]: Snippets can't target based on bookmarks
Depends on: 1459655
User Story: (updated)
Comment on attachment 8975120 [details]
Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

https://reviewboard.mozilla.org/r/243486/#review249346
Attachment #8975120 - Flags: review?(edilee) → review+
Comment on attachment 8975120 [details]
Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

Approval Request Comment
[Feature/Bug causing the regression]: this bug prevents the snippets from being able to access the bookmarks count for targeting purposes
[User impact if declined]: Targeting on bookmarks will be broken
[Is this code covered by automated tests?]: yes, in activity stream unit tests
[Has the fix been verified in Nightly?]: it will be landing soon
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: this is a one-line fix that has been previously reviewed and tested by Activity Stream reviewers
[String changes made/needed]: no
Attachment #8975120 - Flags: approval-mozilla-beta?
Pushed by khudson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17ed43c1c76b
gSnippetsMap.getTotalBookmarksCount() never resolves r=Mardak
Target Milestone: --- → Firefox 62
Comment on attachment 8975120 [details]
Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

Ensure that bookmarks are accessible to the snippets code. Approved for 61.0b5.
Attachment #8975120 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
User Story: (updated)
Blocks: 1462736
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.