1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

See https://github.com/mozmeao/snippets-service/pull/395#issuecomment-385320405

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4145

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/71ff8f317d16f48747f3ef321854616c1981d286
Fix Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves (#4145)

* Fix Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

* undo change

Comment 3

[Ed Lee :Mardak]

[Tracking Requested - why for this release]: Snippets can't target based on bookmarks

Comment 4

[Kate Hudson :k88hudson]

Attachment: Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

Review commit: https://reviewboard.mozilla.org/r/243486/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243486/

Comment 5

[Ed Lee :Mardak]

Comment on attachment 8975120 [details]
Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

https://reviewboard.mozilla.org/r/243486/#review249346

Comment 6

[Kate Hudson :k88hudson]

Comment on attachment 8975120 [details]
Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

Approval Request Comment
[Feature/Bug causing the regression]: this bug prevents the snippets from being able to access the bookmarks count for targeting purposes
[User impact if declined]: Targeting on bookmarks will be broken
[Is this code covered by automated tests?]: yes, in activity stream unit tests
[Has the fix been verified in Nightly?]: it will be landing soon
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: this is a one-line fix that has been previously reviewed and tested by Activity Stream reviewers
[String changes made/needed]: no

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17ed43c1c76b
gSnippetsMap.getTotalBookmarksCount() never resolves r=Mardak

Comment 8

[Sebastian Hengst [:aryx] [limited availability until start of 2020] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/17ed43c1c76b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8975120 [details]
Bug 1460119 - gSnippetsMap.getTotalBookmarksCount() never resolves

Ensure that bookmarks are accessible to the snippets code. Approved for 61.0b5.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/43bcbb69db21