Closed Bug 1460147 Opened Last year Closed Last year

netwerk/protocol/http/HttpChannelChild.cpp:1797:3: error: 'PROFILER_ADD_NETWORK_MARKER' was not declared in this scope

Categories

(Core :: Gecko Profiler, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

(Keywords: regression)

Attachments

(1 file)

On Tier3 platforms without GeckoProfiler (iOS, Linux powerpc/sparc, BSDs, Solaris) the build is broken because PROFILER_ADD_NETWORK_MARKER() stub is missing. To reproduce on Tier1 platforms before bug 1371159 is fixed adjust gecko_profiler() in toolkit/moz.configure to return None.

$ c++ -v
FreeBSD clang version 6.0.0 (tags/RELEASE_600/final 326565) (based on LLVM 6.0.0)
Target: x86_64-unknown-freebsd12.0
Thread model: posix
InstalledDir: /usr/bin

$ ./mach bootstrap
$ ./mach build
[...]
In file included from objdir/netwerk/protocol/http/Unified_cpp_protocol_http0.cpp:137:
netwerk/protocol/http/HttpChannelChild.cpp:1797:59: error: use of undeclared identifier
      'NetworkLoadType'
  PROFILER_ADD_NETWORK_MARKER(mURI, mPriority, channelId, NetworkLoadType::LOAD_REDIRECT,
                                                          ^
netwerk/protocol/http/HttpChannelChild.cpp:2529:60: error: use of undeclared identifier
      'NetworkLoadType'
  PROFILER_ADD_NETWORK_MARKER(mURI, mPriority, mChannelId, NetworkLoadType::LOAD_START,
                                                           ^
2 errors generated.
According to bug 1403868 some out-of-tree consumers maybe affected as well.
Comment on attachment 8974241 [details]
Bug 1460147 - Unbreak platforms without GeckoProfiler after bug 1457323.

https://reviewboard.mozilla.org/r/242542/#review248628

Thanks! And sorry for not catching it.
Attachment #8974241 - Flags: review?(mstange) → review+
Keywords: checkin-needed
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/45697af1f4e6
Unbreak platforms without GeckoProfiler after bug 1457323. r=mstange
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/45697af1f4e6
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee: nobody → jbeich
You need to log in before you can comment on or make changes to this bug.