Closed Bug 1460180 Opened 3 years ago Closed 3 years ago

Remove the RDF atoms

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(1 file)

They aren't used now that rdf/ is gone.
Comment on attachment 8974249 [details]
Bug 1460180 - Remove the RDF atoms.

https://reviewboard.mozilla.org/r/242566/#review248580
Attachment #8974249 - Flags: review?(nfroyd) → review+
This will make it a bit harder for Thunderbird to move the RDF service into comm-central, but I suppose they'll find a workaround.
Oooh, that's a good point; I hadn't thought about that.  Thunderbird has no good way of injecting static atoms.

I guess we could make those atoms conditional on some Thunderbird-specific #define?
(In reply to Nathan Froyd [:froydnj] from comment #4)
> Oooh, that's a good point; I hadn't thought about that.  Thunderbird has no
> good way of injecting static atoms.
> 
> I guess we could make those atoms conditional on some Thunderbird-specific
> #define?

I think that would probably be reasonable, yeah. Maybe just `#ifdef MOZ_RDF_SERVICE` and let them define it when they're building with RDF.
Comment on attachment 8974249 [details]
Bug 1460180 - Remove the RDF atoms.

https://reviewboard.mozilla.org/r/242566/#review248614

::: xpcom/ds/nsGkAtomList.h:2488
(Diff revision 1)
>  GK_ATOM(nsuri_xhtml, "http://www.w3.org/1999/xhtml")
>  GK_ATOM(nsuri_xlink, "http://www.w3.org/1999/xlink")
>  GK_ATOM(nsuri_xslt, "http://www.w3.org/1999/XSL/Transform")
>  GK_ATOM(nsuri_xbl, "http://www.mozilla.org/xbl")
>  GK_ATOM(nsuri_mathml, "http://www.w3.org/1998/Math/MathML")
>  GK_ATOM(nsuri_rdf, "http://www.w3.org/1999/02/22-rdf-syntax-ns#")

I believe this can go, too, along with the reference in nsNameSpaceManager.
Or how about:
// Thunderbird and Seamonkey still use the RDF service.
#if defined(MOZ_THUNDERBIRD) || defined(MOZ_SUITE)
(In reply to Jorg K (GMT+1) from comment #7)
> Or how about:
> // Thunderbird and Seamonkey still use the RDF service.
> #if defined(MOZ_THUNDERBIRD) || defined(MOZ_SUITE)

I'd rather avoid those kind of app-specific ifdefs. You know at build time whether you're building the RDF service. You should be able to define a specific feature macro easily enough.

It also makes it easier to find code that needs to be excised when the RDF service is finally removed from comm-central.
Depends on: 857458, 857456
No longer depends on: 857456
No longer depends on: 857458, 833098
All static atoms are now in a single place (nsGkAtoms) and generated from scripts. This makes conditional definition of atoms pretty much impossible. So I'm going to leave the RDF atoms in the list. I have landed a patch that adds a comment explaining that they are used in comm-central.
https://hg.mozilla.org/mozilla-central/rev/4f27d46e7abe
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.