Closed Bug 1460190 Opened 6 years ago Closed 6 years ago

Firefox Nightly can't open site after typing address into address bar, and can't open search engines in search bar.

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
61 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 62
Tracking Flags:
Tracking Status
firefox62 --- verified

People

(Reporter: buhler.av, Assigned: mkaply)

References

Details

Attachments

(1 file)

Bug 1460190 - Handle search regions with default but no enginelist.
59 bytes, text/x-review-board-request
adw
: review+
Details 
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180427210249

Steps to reproduce:

There is some cretical bugs in current nightly build (09.05.2018).

If you type address of new web-site into address bar and then push "Enter", there is no reaction. Firefox Nightly does not attempt to download web-page from entered address.

And simultaneously, Firefox shows no rearch engines in search bar, which is in right side from address bar.

I am sure that it is not related with my profile, because I made Firefox Refreshment, then launch Nithtly with new file, then reinstall Nithly with Geek Uninstaller.

And finally I installed stable version of Firefox (59.0.3).

I don't remember current Version branch of Nithtly (09.05.2018), therefore version number which I point out in this request "61 branch" could be mistaken. Please check version of today Nightly.

There is no screenshots or videos, because I am happy that stable version of Firefox, which I just installed, works fine and I don't want to perform procedures again.


Actual results:

There is some cretical bugs in current nightly build (09.05.2018).

If you type address of new web-site into address bar and then push "Enter", there is no reaction. Firefox Nightly does not attempt to download web-page from entered address.

And simultaneously, Firefox shows no rearch engines in search bar, which is in right side from address bar.

I am sure that it is not related with my profile, because I made Firefox Refreshment, then launch Nithtly with new file, then reinstall Nithly with Geek Uninstaller.

And finally I installed stable version of Firefox (59.0.3).

I don't remember current Version branch of Nithtly (09.05.2018), therefore version number which I point out in this request "61 branch" could be mistaken. Please check version of today Nightly.


There is no screenshots or videos, because I am happy that stable version of Firefox, which I just installed, works fine and I don't want to perform procedures again.


Expected results:

There is some cretical bugs in current nightly build (09.05.2018).

If you type address of new web-site into address bar and then push "Enter", there is no reaction. Firefox Nightly does not attempt to download web-page from entered address.

And simultaneously, Firefox shows no rearch engines in search bar, which is in right side from address bar.

I am sure that it is not related with my profile, because I made Firefox Refreshment, then launch Nithtly with new file, then reinstall Nithly with Geek Uninstaller.

And finally I installed stable version of Firefox (59.0.3).

I don't remember current Version branch of Nithtly (09.05.2018), therefore version number which I point out in this request "61 branch" could be mistaken. Please check version of today Nightly.


There is no screenshots or videos, because I am happy that stable version of Firefox, which I just installed, works fine and I don't want to perform procedures again.
Please check the issue.
Flags: needinfo?(mconley)
Flags: needinfo?(dd.mozilla)
I cannot reproduce it. I do not know anything that landed in necko recently that could cause this. This may be address bar issue. Let's ask there.
Flags: needinfo?(dd.mozilla)
Component: Untriaged → Address Bar
I've seen that behavior when we broken 52 ESR for Italian (bug 1445278). There were no XML files in the build.

A change that centralizes the search default (bug 1352539) just landed, no clue if that could be related.

@alexandr
Was that an English build, or a different language?
Flags: needinfo?(buhler.av)
Looks like this affects only localized builds. An user on a Russian support forum have posted following workaround for this bug: about:config -> change "browser.search.countryCode" to "EN" and change "browser.search.region" to "EN".
EN is an invalid code for both region and countryCode.

I just installed the Russian nightly and search is working fine for me and defaulting correctly. 

I even changed my codes to RU and readded search and everything works.

What I need is to know what browser.search.countryCode and region were before they changed.

And if someone could look on the console to see if there is an error.
Flags: needinfo?(mconley)
Hm, I can not reproduce it with new profile, but I can reproduce it with my current profile:
1) Download http://ftp.mozilla.org/pub/firefox/nightly/latest-mozilla-central-l10n/firefox-62.0a1.ru.linux-x86_64.tar.bz2
2) Start browser with not-new profile
3) Open about:preferences
4) In about:preferences you can not select "Search" pane with mouse click. In browser console there are following messages:

uncaught exception: 2147500037 ContentSearch.jsm:504:9
[Показать/скрыть детали сообщения.] [Exception... "Failure'Failure' when calling method: [nsIBrowserSearchService::currentEngine]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/ContentSearch.jsm :: _currentEngineObj :: line 504"  data: no]
[Показать/скрыть детали сообщения.] TypeError: this.defaultEngine is undefined contentSearchUI.js:624:5
[Показать/скрыть детали сообщения.] XHRPOST
https://tiles.services.mozilla.com/v3/links/ping-centre
[HTTP/1.1 200 OK 902ms]
[Показать/скрыть детали сообщения.] XHRPOST
https://tiles.services.mozilla.com/v4/links/activity-stream
[HTTP/1.1 200 OK 767ms]
[Показать/скрыть детали сообщения.] XHRGET
https://aus5.mozilla.org/update/6/Firefox/62.0a1/20180509100510/Linux_x86_64-gcc3/ru/nightly/Linux%204.16.7-1-ARCH%20(GTK%203.22.30%2Clibpulse%2011.1.0)/ISET:SSE3,MEM:3947/default/default/update.xml?force=1
[HTTP/1.1 200 OK 939ms]
uncaught exception: 2147500037 search.js:416:19
[Показать/скрыть детали сообщения.] NS_ERROR_FAILURE: Failure'Failure' when calling method: [nsIBrowserSearchService::getVisibleEngines] search.js:416
uncaught exception: 2147500037 search.js:416:19
[Показать/скрыть детали сообщения.] Error initializing preference category paneSearch: [Exception... "Failure'Failure' when calling method: [nsIBrowserSearchService::getVisibleEngines]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/preferences/in-content/search.js :: EngineStore :: line 416"  data: no] preferences.js:162
gotoPref
chrome://browser/content/preferences/in-content/preferences.js:162:5
init_all/<
chrome://browser/content/preferences/in-content/preferences.js:70:50
_fireOnSelect
chrome://global/content/bindings/richlistbox.xml:78:13
selectItem
chrome://global/content/bindings/listbox.xml:237:11
onxblmousedown
chrome://global/content/bindings/listbox.xml:995:13
[Показать/скрыть детали сообщения.] NS_ERROR_FAILURE: Failure'Failure' when calling method: [nsIBrowserSearchService::getVisibleEngines] search.js:416
Interesting. Would you be willing to send me your prefs.js (I just need the browser.search.* sections) and the file search.json.mozlz4?

That would help me debug this. I don't know what could be going wrong here.
(In reply to Mike Kaply [:mkaply] from comment #7)
> Interesting. Would you be willing to send me your prefs.js (I just need the
> browser.search.* sections) and the file search.json.mozlz4?
> 
> That would help me debug this. I don't know what could be going wrong here.

Sent by e-mail.
I use Russian x64 build.

I performed the following steps to fix problem with my Firefox:

1. I performed profile refreshment https://support.mozilla.org/en-US/kb/refresh-firefox-reset-add-ons-and-settings . It gives no effect.
2. I tried to backup profile and perform couple of cycles of uninstallation/installation Nightly with CrystalIdea Uninstall Tool and Geek Uninstaller. It gives no effect.
3. I tried to clean system with Auslogics BoostSpeed, Reg Organizer, CCleaner, and then installation of Nightly. It gives no effect.
4. Finally I download installer of stable Firefox version. After launching it detects some traces of previous Firefox installations, performs uninstallation, and finally install Stable version of Firefox. And only after launching this stable Firefox installation I recognize that address bar loads web-sites and search bar has list of search engines.

I am really apologize, that I did not save Nightly Installation with bugs, because I am afraid that my attempts to fix problem erase evidence, which is responsible for bug.

It was really old Firefox profile and Nightly installation with a lot of everyday update cycles. I had another bug Bug 1368974 . But it was finally fixed.

You should design special tool for users. If user detects bug, he launches special utility, which collect all parameters of firefox and system itself. After that user can send report to developers and perform reinstallation/refreshment procedures with sureness, that all bug evidences are collected.


There is file uninstall.log in folder C:\Program Files\Mozilla Firefox\uninstall 

https://drive.google.com/open?id=1XwlbR9R7jBt_vGviW1m-wtGGly59TWdo

And install log in folder C:\Program Files\Mozilla Firefox

https://drive.google.com/open?id=1aBfAB9Vum1JOBIYlf31wsF03u-2WYuTe


New messages arrived in the meantime with writing of this message by me. I will read them and make updates.
Does installer of stable Firefox collects any install/uninstall logs in other places? Where I can find it and forward to you?

I will try to plug initial, not refreshed profile into my current firefox. It it will shows bug, I will report to you.
Flags: needinfo?(unghost)
Flags: needinfo?(mozilla)
Flags: needinfo?(buhler.av)
(In reply to Mike Kaply [:mkaply] from comment #7)
> Interesting. Would you be willing to send me your prefs.js (I just need the
> browser.search.* sections) and the file search.json.mozlz4?
> 
> That would help me debug this. I don't know what could be going wrong here.

Looks like your mail provider has blocked my message, cause "its content presents a potential 552-5.7.0 security issue". I've put these files in archive on https://yadi.sk/d/14zYyxV63VdD4A
(In reply to Alexandr Buller from comment #10)
> Does installer of stable Firefox collects any install/uninstall logs in
> other places? Where I can find it and forward to you?

Note that I'm aware of. In case, the issue is within the profile, and it's not removed by uninstalling.

At this point, I don't think your profile is useful, because the data was already "fixed" by installing Release.
Status: UNCONFIRMED → NEW
Component: Address Bar → Search
Ever confirmed: true
Flags: needinfo?(unghost)
Flags: needinfo?(mozilla)
I am able to recreate with the files from Alexander. Debugging now.
I thnk I know what's going on here. It definitely l10n only and only on the Russian builds.

That's why I couldn't recreate. Working on a fix.
Assignee: nobody → mozilla
Summary: Firefox Nithtly can't open site after typing address into address bar, and can't open search engines in search bar. → Firefox Nightly can't open site after typing address into address bar, and can't open search engines in search bar.
zhCN locale have the same problem.
Given the patch, I'd expect the following locales to have the issue: be, kk, ru, tr, zh-CN.
I am using firefox nightly 62.0a1 (2018-05-10) (64 bit)

duckduckgo as default search engine and my locale is 'tr'

I have the same issue
(In reply to Alexandr Buller from comment #0)
> If you type address of new web-site into address bar and then push "Enter",
> there is no reaction.

Wait wait wait, is this really only a problem related to search engines?  Typing a URL and hitting enter doesn't have anything to do with search, right?  There may be multiple problems here.  We've had problems recently with the urlbar not responding to enter keypresses that didn't have anything to do with search.

Mike, can you reproduce this part of the bug?
(In reply to Drew Willcoxon :adw from comment #19)
> We've had problems recently with the urlbar not responding to enter keypresses
> that didn't have anything to do with search.

Which we thought we finally fixed
(In reply to Drew Willcoxon :adw from comment #19)
> (In reply to Alexandr Buller from comment #0)
> > If you type address of new web-site into address bar and then push "Enter",
> > there is no reaction.
> 
> Wait wait wait, is this really only a problem related to search engines? 
> Typing a URL and hitting enter doesn't have anything to do with search,
> right?  There may be multiple problems here.  We've had problems recently
> with the urlbar not responding to enter keypresses that didn't have anything
> to do with search

Based on experience from bug 1445278: empty list of searchplugins makes the browser basically unusable. Not only the address bar is completely broken, even the context menu was acting strange.
Hello
I have to add this information

as well as the search from address bar issue
I have a problem with search tab in settings. 

When I click search on settings it gets highlighted but options doesn't change.
i have reproduced the bug and it is definitely a search bug. And the folks that are seeing it are exactly the ones I would expect based on their location. 

If anyone besides adw wants to review the patch, feel free so it goes in faster.
I am using nightly zh_CN 62.0a1 (2018-05-09) (64-bit) on Arch Linux x86_64 and macOS 10.13.3 on a MacBook Air, both builds have the following problems.

1. typing text into address bar and hit enter gives no response, and the 'search suggestion' list didn't show up;
2. typing text into search bar has the same behavior as above;
3. the search engine selector menu lists no search engines;
4. in Preferences, clicking the 'Search' section didn't do anything;
5. BUT, you can open search preference by directly going to 'about:preferences#search', and there is no search engine in the list at all;
6. ALSO, in the address bar, you can actually go to websites by completing the URL scheme, e.g. use 'https://www.google.com' or 'mailto:abc@example.org' or 'steam://...' will open the website or corresponding program.

Both 'browser.search.countryCode' and 'browser.search.region' are "CN".

By this far, I've tried several methods...

1. replace zh_CN nightly with the same version of en_US nightly. This gives back the normal behavior, and I checked that search countryCode and region are still "CN";

2. fully quit nightly and open Firefox stable 60.0, this also gives normal behavior;

3. quit Firefox stable, install and open zh_CN nightly (the same version used above), the address bar and search bar malfunctions again.
Comment on attachment 8974616 [details]
Bug 1460190 - Handle search regions with default but no enginelist.

https://reviewboard.mozilla.org/r/242986/#review249048

OK, thanks
Attachment #8974616 - Flags: review?(adw) → review+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/6327e477e665
Handle search regions with default but no enginelist. r=adw
I have all this problems. Also can't google search some text using pop up window.
I'm from Russia.
Hopefully this will land this morning (CET time) in mozilla-central, and will be available before the end of the day in the Nightly update.
Also can't open link in new tab
https://hg.mozilla.org/mozilla-central/rev/6327e477e665
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
The same issue on the Android version of Firefox Nightly. Locale: ru
Can someone confirm if the problem in Nightly (desktop) was fixed? 

If that doesn't work, please provide the complete version from the about window (including date). Even better, also the "Build from" info available in about:buildconfig
I can confirm. It fixed for me.
Android version is also looks like fixed.
Regression in latest Nightly build?
Built from https://hg.mozilla.org/mozilla-central/rev/da28b92efe6f6acaf79545697415b82038143338
Locale: ru

Search engines disappeared. Can't search. Also I can't open "Search" in about:preferences
Clean profile doesn't help

There's error in my console:

> TypeError: this.defaultEngine is undefined[Подробнее] contentSearchUI.js:624:5
> _updateDefaultEngineHeader
> chrome://browser/content/contentSearchUI.js:624:5
> _onMsgStrings
> chrome://browser/content/contentSearchUI.js:608:5
> _onContentSearchService
> chrome://browser/content/contentSearchUI.js:514:7
> handleEvent
> chrome://browser/content/contentSearchUI.js:226:5
> _fireEvent
> chrome://browser/content/tab-content.js:291:5
> receiveMessage
> chrome://browser/content/tab-content.js:269:7
Dmitriy, this issue was confirmed as fixed a few weeks ago, please can you file a new bug for your issue.
I have reproduced this issue using Firefox 62.0a1 (2018.06.05) Russian build, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Firefox 62.0b7 Russian build on Ubuntu 16.04 x64, Windows 10 x64 and Mac OS X 10.13.5, also I done some exploratory testing and I didn't found any issues.
Status: RESOLVED → VERIFIED
status-firefox62: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: