Closed
Bug 1460201
Opened 7 years ago
Closed 7 years ago
Port bug 1387143: replace use of nsISelection in TB
Categories
(MailNews Core :: General, enhancement)
MailNews Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 62.0
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
Details
Attachments
(2 files, 1 obsolete file)
|
9.18 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
|
3.47 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Not as bad as it sounds, we use it in mailnews/compose/src/nsMsgCompose.cpp and mailnews/compose/src/nsMsgComposeService.cpp.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8974287 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Removed unnecessary 'mozilla::dom::' since nsMsgCompose.cpp uses namespace mozilla::dom.
Attachment #8974287 -
Attachment is obsolete: true
Attachment #8974287 -
Flags: review?(bzbarsky)
Attachment #8974289 -
Flags: review?(bzbarsky)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/53935b1644c4
Port bug 1387143: replace use of nsISelection. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8974289 [details] [diff] [review]
1460201-nsISelection.patch (v1b)
r=me
Attachment #8974289 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Updated•7 years ago
|
Target Milestone: --- → Thunderbird 62.0
This bug didn't remove nsISelectionPrivate which is also gone.
I made a patch according to https://bug1387143.bmoattachments.org/attachment.cgi?id=8973087 .
Attachment #8975127 -
Flags: review?(bzbarsky)
|
|
||
Updated•7 years ago
|
Attachment #8975127 -
Flags: review?(bzbarsky) → review+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/c07f80f07067
Follow-up: remove use of nsISelectionPrivate in C-C. r=bz DONTBUILD
You need to log in
before you can comment on or make changes to this bug.
Description
•