Closed
Bug 1460210
Opened 7 years ago
Closed 7 years ago
Don't use GetProcAddress on Parental Control code
Categories
(Toolkit :: General, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: m_kato, Assigned: m_kato)
Details
Attachments
(1 file)
|
6.03 KB,
patch
|
away
:
review+
|
Details | Diff | Splinter Review |
Since we doesn't support WinXP and Vista, it is unnecessary to use GetProcAddress for Parental Control support.
| Assignee | ||
Comment 1•7 years ago
|
||
| Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8974295 [details] [diff] [review]
Remove unnecessary GetProcAddress for parental control
Since we don't support XP and Vista, it is unnecessary to use GetProcAddress for parental control APIs.
Attachment #8974295 -
Flags: review?(dmajor)
Comment on attachment 8974295 [details] [diff] [review]
Remove unnecessary GetProcAddress for parental control
There's an unbalanced CoInitialize in the constructor that might warrant a followup bug.
Attachment #8974295 -
Flags: review?(dmajor) → review+
Updated•7 years ago
|
Priority: -- → P3
| Assignee | ||
Comment 4•7 years ago
|
||
(In reply to David Major [:dmajor] from comment #3)
> Comment on attachment 8974295 [details] [diff] [review]
> Remove unnecessary GetProcAddress for parental control
>
> There's an unbalanced CoInitialize in the constructor that might warrant a
> followup bug.
filed as bug 1461233
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/354b5292689e
Don't use GetProcAddress on Parental Control code. r=dmajor
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•