1460272 - prevent landing when the author is "unknown"

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[:glob ✱]

diffs uploaded via the web ui or created using an older version of phabsend do not set diff authors.

as lando is unable to access the email address of the phabricator account we don't have anything yet to fallback to when the author is missing.

we should block landing of diffs with unknown authors.
the error returned should state to use 'arc' to re-upload to phabricator.

Comment 1

[Mark Côté [:mcote]]

I hate to do it, but this should probably block general release, just due to the frequency at which this problem has occurred lately.  Feel free to push back though.

Comment 2

[Phabricator Automation]

Attachment: landings: block landing when diff author is unknown (Bug 1460272).

Diffs uploaded using the web UI or some clients other than arc may not
have proper commit author information associated with them. Since we
don't currently have a sane fallback for the author name and email to
use, we should prevent landing these diffs. This change introduces the
`DiffAuthorUnknown` `LandingProblem` that checks for this specific case.

Comment 3

[Phabricator Automation]

Comment on attachment 8976680 [details]
landings: block landing when diff author is unknown (Bug 1460272).

Israel Madueme [:imadueme] has approved the revision.

https://phabricator.services.mozilla.com/D1308

Comment 4

[Steven MacLeod [:smacleod]]

https://github.com/mozilla-conduit/lando-api/commit/dbc9cc5db9cef501f41ce172b282e3c4e096e59e