Closed
Bug 1460289
Opened 6 years ago
Closed 6 years ago
Deadlock with async scene building
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: kats, Assigned: kats)
References
Details
(Whiteboard: [gfx-noted])
Attachments
(2 files)
I ran into a deadlock on nightly, the root cause is that we hold the sIndirectLayerTrees lock in RecvAdoptChild when we clone the WebRenderAPI. That blocks on the render backend thread, which is blocked on the scene builder thread, which is trying to acquire the sIndirectLayerTreesLock. Thread stacks attached. The fix should be to not hold the sIndirectLayerTreesLock while cloning the WebRenderAPI.
|
Assignee | |
Comment 1•6 years ago
|
||
This is basically another variant of https://bugzilla.mozilla.org/show_bug.cgi?id=1457246
See Also: → 1457246
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd5d467bd5d2a24c9e56d97e0a8600472ce7a89b
|
|
Assignee | |
Comment 3•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f23215218e54eba613aa36f15a2534bc3ed0c02d
| Comment hidden (mozreview-request) |
|
||
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8974502 [details] Bug 1460289 - Reduce scope of indirect layer tree lock in RecvAdoptChild. https://reviewboard.mozilla.org/r/242828/#review248764 good catch!
Attachment #8974502 -
Flags: review?(sotaro.ikeda.g) → review+
Pushed by kgupta@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc2188a4b2d9 Reduce scope of indirect layer tree lock in RecvAdoptChild. r=sotaro
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc2188a4b2d9
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•