1460310 - Fix http version identifiers returned from nsAHttpConnection::Version

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P3)

Description

[u408661]

Generally speaking, nsAHttpConnection::Version should return one of the NS_HTTP_VERSION_# identifiers. But, in the case where we're running H2, we end up returning HTTP_VERSION_2 (=5) instead of NS_HTTP_VERSION_2_0 (=20). The HTTP_VERSION_2 value should really only be used to (1) indicate that a connection is spdy (we may be able to make this a bool in that case, too), and (2) as an identifier in the SpdyInfo table.

We should probably make nsAHttpConnection::Version return some sort of typed enum so that we don't accidentally get in this state again when we add a future protocol (When You Least Expect It!)

Comment 1

[u408661]

Attachment: Bug 1460310 - Separate HTTP and SPDY identifiers into separate namespaces.

Review commit: https://reviewboard.mozilla.org/r/248578/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/248578/

Comment 2

[u408661]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a47bcfe511042d34bd01c6acd85fcebb32b4142f

Comment 3

[Patrick McManus [:mcmanus]]

thought just occurred to me - as part of the review plz make sure that any constant used in telemetry is preserved

Comment 4

[Dragana Damjanovic [:dragana]]

Comment on attachment 8982623 [details]
Bug 1460310 - Separate HTTP and SPDY identifiers into separate namespaces.

https://reviewboard.mozilla.org/r/248578/#review255594

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a6e61fb1666
Separate HTTP and SPDY identifiers into separate namespaces. r=dragana

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6a6e61fb1666