Closed Bug 1460312 Opened Last year Closed Last year

Crash in nsCOMPtr_base::assign_assuming_AddRef | OCSPRequest::OnTimeout

Categories

(Core :: Security: PSM, defect, P1, critical)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 --- fixed

People

(Reporter: calixte, Assigned: keeler)

References

(Blocks 1 open bug)

Details

(Keywords: crash, regression, Whiteboard: [psm-assigned])

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is
report bp-35e2b27a-0ff9-4184-b677-4c95b0180509.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll nsCOMPtr_base::assign_assuming_AddRef xpcom/base/nsCOMPtr.h:355
1 xul.dll OCSPRequest::OnTimeout security/manager/ssl/nsNSSCallbacks.cpp:435
2 xul.dll nsTimerImpl::Fire xpcom/threads/nsTimerImpl.cpp:701
3 xul.dll nsTimerEvent::Run xpcom/threads/TimerThread.cpp:290
4 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1090
5 xul.dll mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:97
6 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:319
7 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:299
8 xul.dll nsBaseAppShell::Run widget/nsBaseAppShell.cpp:157
9 xul.dll nsAppShell::Run widget/windows/nsAppShell.cpp:401

=============================================================

There is 1 crash in nightly 62 with buildid 20180509100510. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1456489.

[1] https://hg.mozilla.org/mozilla-central/rev?node=47d306cfac90
Flags: needinfo?(dkeeler)
Turns out we actually do need to cancel the timer, because otherwise the OCSPRequest might go away and `self` won't be valid.
Assignee: nobody → dkeeler
Flags: needinfo?(dkeeler)
Priority: -- → P1
Whiteboard: [psm-assigned]
Comment on attachment 8974458 [details]
bug 1460312 - cancel the timeout timer in OCSP request implementation

https://reviewboard.mozilla.org/r/242810/#review248640

LGTM.
Attachment #8974458 - Flags: review?(jjones) → review+
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/28452fd08a41
cancel the timeout timer in OCSP request implementation r=jcj
https://hg.mozilla.org/mozilla-central/rev/28452fd08a41
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.