59 bytes, text/x-review-board-request
... and if it gets a CNAME back, check if the address record for that CNAME is actually in fact already provided in the DNS packet that passed on the CNAME!
Comment on attachment 8974724 [details] bug 1460327 - make the DNS packet decoder verify the answer qname https://reviewboard.mozilla.org/r/243098/#review248916 please add a test where the response contains a mismatched name so we make sure not to use it
Attachment #8974724 - Flags: review?(mcmanus) → review+
I pushed an update with fixed tests (since the previous ones violated the qnames quite a bit) and two new tests to make sure this new logic works as intended to. Feel free to give it a second look, or not. The try-run looks fine so I'm otherwise ready to land this.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/0f7100b128f2 make the DNS packet decoder verify the answer qname r=mcmanus
You need to log in before you can comment on or make changes to this bug.