Closed Bug 1460367 Opened 2 years ago Closed 2 years ago

move audio sample-related settings to moz.configure

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file, 1 obsolete file)

With moz.configure, it's a little more obvious that MOZ_TREMOR and
MOZ_VORBIS are mutually exclusive.
Attachment #8974469 - Flags: review?(core-build-config-reviews)
Comment on attachment 8974469 [details] [diff] [review]
move audio sample-related settings to moz.configure

Review of attachment 8974469 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/moz.configure
@@ +439,5 @@
> +
> +set_define('MOZ_VORBIS', sample_type_is_float)
> +set_config('MOZ_VORBIS', sample_type_is_float)
> +set_define('MOZ_TREMOR', sample_type_is_s16)
> +set_config('MOZ_TREMOR', sample_type_is_s16)

Seems like it might be nice to have a better shorthand for this sort of thing, this feels very repetitive. (Still beats reading m4+shell, though!)
Attachment #8974469 - Flags: review?(core-build-config-reviews) → review+
Comment on attachment 8974469 [details] [diff] [review]
move audio sample-related settings to moz.configure

Review of attachment 8974469 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/moz.configure
@@ +433,5 @@
> +        return True
> +
> +set_config('MOZ_SAMPLE_TYPE_S16', sample_type_is_s16)
> +set_define('MOZ_SAMPLE_TYPE_S16', sample_type_is_s16)
> +set_config('MOZ_SAMPLE_TYPE_FLOAT', sample_type_is_float)

In the configure file, this was `MOZ_SAMPLE_TYPE_FLOAT32`.  I don't think this rename is safe.
Attachment #8974469 - Flags: review+ → review-
nalexander saves me from breaking the tree.  Carrying over ted's r+.
Attachment #8974495 - Flags: review+
Attachment #8974469 - Attachment is obsolete: true
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/758cb28b7014
move audio sample-related settings to moz.configure; r=ted.mielczarek,nalexander
https://hg.mozilla.org/mozilla-central/rev/758cb28b7014
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.