Closed
Bug 1460367
Opened 6 years ago
Closed 6 years ago
move audio sample-related settings to moz.configure
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file, 1 obsolete file)
|
5.31 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
With moz.configure, it's a little more obvious that MOZ_TREMOR and MOZ_VORBIS are mutually exclusive.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8974469 -
Flags: review?(core-build-config-reviews)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8974469 [details] [diff] [review] move audio sample-related settings to moz.configure Review of attachment 8974469 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/moz.configure @@ +439,5 @@ > + > +set_define('MOZ_VORBIS', sample_type_is_float) > +set_config('MOZ_VORBIS', sample_type_is_float) > +set_define('MOZ_TREMOR', sample_type_is_s16) > +set_config('MOZ_TREMOR', sample_type_is_s16) Seems like it might be nice to have a better shorthand for this sort of thing, this feels very repetitive. (Still beats reading m4+shell, though!)
Attachment #8974469 -
Flags: review?(core-build-config-reviews) → review+
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8974469 [details] [diff] [review] move audio sample-related settings to moz.configure Review of attachment 8974469 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/moz.configure @@ +433,5 @@ > + return True > + > +set_config('MOZ_SAMPLE_TYPE_S16', sample_type_is_s16) > +set_define('MOZ_SAMPLE_TYPE_S16', sample_type_is_s16) > +set_config('MOZ_SAMPLE_TYPE_FLOAT', sample_type_is_float) In the configure file, this was `MOZ_SAMPLE_TYPE_FLOAT32`. I don't think this rename is safe.
Attachment #8974469 -
Flags: review+ → review-
|
|
Assignee | |
Comment 4•6 years ago
|
||
nalexander saves me from breaking the tree. Carrying over ted's r+.
Attachment #8974495 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8974469 -
Attachment is obsolete: true
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/758cb28b7014 move audio sample-related settings to moz.configure; r=ted.mielczarek,nalexander
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/758cb28b7014
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•