Closed
Bug 1460379
Opened 6 years ago
Closed 6 years ago
remove --with-pthreads option
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
2.94 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
This option does nothing if it's provided, and things will probably break in some most peculiar manner if somebody uses --without-pthreads. Given that neither outcome is useful, we should remove the option.
|
Assignee | |
Comment 1•6 years ago
|
||
Goodbye worthless options.
Attachment #8974483 -
Flags: review?(core-build-config-reviews)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8974483 [details] [diff] [review] remove --with-pthreads option Review of attachment 8974483 [details] [diff] [review]: ----------------------------------------------------------------- Good riddance!
Attachment #8974483 -
Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e61af28c3143 remove --with-pthreads option; r=ted.mielczarek
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e61af28c3143
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•