Closed Bug 1460380 Opened 6 years ago Closed 6 years ago

Apply the Dark/Light theme to the quick-filter-bar too

Categories

(Thunderbird :: Theme, enhancement)

Product:
Thunderbird
Component:
Theme
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr60 fixed, thunderbird60 fixed, thunderbird61 wontfix, thunderbird62 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 62.0
Tracking Flags:
Tracking Status
thunderbird_esr60 --- fixed
thunderbird60 --- fixed
thunderbird61 --- wontfix
thunderbird62 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(4 files, 1 obsolete file)

1460380.png
3.97 KB, image/png
Details
theme-QFB.patch
15.87 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review
quickfilter.png
178.50 KB, image/png
Details
Bug1460380-more-specific.patch
1.73 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
jorgk-bmo
: approval-comm-esr60+
Details | Diff | Splinter Review 
I propose to make the Quick Filter Bar also themeable by the Dark/Light themes.
Attached patch theme-QFB.patch (obsolete) — — Splinter Review 
What do you think about this? I'm using like in composer the header bar the second colour to separate the bar from the main toolbar.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8974487 - Flags: review?(jorgk)
Attached image 1460380.png — 
Your patch shows that there is something wrong with the QFB icons. The pin and the star are brighter.
Attached patch theme-QFB.patch — — Splinter Review 
Good catch. Both images had no fill-opacity="context-fill-opacity".
Attachment #8974487 - Attachment is obsolete: true
Attachment #8974487 - Flags: review?(jorgk)
Attachment #8974615 - Flags: review?(jorgk)
Comment on attachment 8974615 [details] [diff] [review]
theme-QFB.patch

Yes, the icons are better now. I don't understand why the QFB is lighter when using the default theme than it is when using the "light" theme. That doesn't appear to be right.
The default theme uses -moz-Dialog as background colour which depends on the OS setting. The Light theme uses a hard coded colour, the one it uses in the tabbar background.
Comment on attachment 8974615 [details] [diff] [review]
theme-QFB.patch

OK then.
Attachment #8974615 - Flags: review?(jorgk) → review+
Thanks.
Keywords: checkin-needed
Comment on attachment 8974615 [details] [diff] [review]
theme-QFB.patch

Okay for TB 60?
Attachment #8974615 - Flags: approval-comm-esr60?
Attachment #8974615 - Flags: approval-comm-beta?
Attachment #8974615 - Flags: approval-comm-esr60?
Attachment #8974615 - Flags: approval-comm-esr60+
Attachment #8974615 - Flags: approval-comm-beta?
Attachment #8974615 - Flags: approval-comm-beta+
Pushed by acelists@atlas.sk:
https://hg.mozilla.org/comm-central/rev/00461a3e5aef
Apply the Dark/Light theme to the quick-filter-bar too. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 62.0
Version: unspecified → Trunk
Attached image quickfilter.png — 
It doesn't appear fixed in TB 60.0b7 on Ubuntu 16.04 LTS.

Tested the TB dark theme in a new install with a test profile.

Noticed the problem in my production version.
I checked this now with 60.b7 on all platforms and it happens only on Linux. It seems it works on Daily because of the overlay removal.

The fix is to make the selector in compacttheme.css more specific than the one in quickFilterBar.css.
Attachment #8985028 - Flags: review?(jorgk)
Attachment #8985028 - Flags: approval-mozilla-esr60?
Comment on attachment 8985028 [details] [diff] [review]
Bug1460380-more-specific.patch

OK, thanks. We're running a TB 60 beta 8, so that will be included. Sorry, I can't approve mozilla-esr60 ;-)
Attachment #8985028 - Flags: review?(jorgk)
Attachment #8985028 - Flags: review+
Attachment #8985028 - Flags: approval-mozilla-esr60?
Attachment #8985028 - Flags: approval-comm-esr60+
Attachment #8985028 - Flags: approval-comm-beta+
Ah chosen the wrong one. :-(
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e3069d31cc24
Make #quick-filter-bar more specific to make it apply over the quickFilterBar.css rule. r=jorgk
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: