Closed
Bug 1460396
Opened 7 years ago
Closed 7 years ago
history.js:242: this is undefined
Categories
(Firefox :: Sync, enhancement)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: eoger, Assigned: eoger)
Details
Attachments
(1 file)
While debugging bug 1460394, I discovered that |this| is undefined here [0] and we can't log the exception we just caught.
[0] https://searchfox.org/mozilla-central/rev/5ff2d7683078c96e4b11b8a13674daded935aa44/services/sync/modules/engines/history.js#242
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8974507 [details]
Bug 1460396 - Make notifyHistoryObservers an arrow function.
https://reviewboard.mozilla.org/r/242842/#review249060
Looks good to me!
Attachment #8974507 -
Flags: review?(tchiovoloni) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77b189833de1
Make notifyHistoryObservers an arrow function. r=tcsc
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in
before you can comment on or make changes to this bug.
Description
•