Closed Bug 1460407 Opened Last year Closed Last year

printf format warning in TestDllInterceptorCrossProcess.cpp

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

Details

Attachments

(1 file)

When a clang-cl build fails for an unrelated reason, this warning appears in the treeherder status window because it contains the string "TEST-UNEXPECTED-FAIL".

> 19:39:14     INFO -  z:/build/build/src/mozglue/tests/interceptor/TestDllInterceptorCrossProcess.cpp(119,112):  warning: format specifies type 'unsigned int' but the argument has type 'DWORD' (aka 'unsigned long') [-Wformat]
> 19:39:14     INFO -      printf("TEST-UNEXPECTED-FAIL | DllInterceptorCrossProcess | Child process exit code is %u instead of 0\n", childExitCode);
> 19:39:14     INFO -                                                                                             ~~                  ^~~~~~~~~~~~~
> 19:39:14     INFO -                                                                                             %lu
Attached patch printfSplinter Review
Assignee: nobody → dmajor
Attachment #8974521 - Flags: review?(aklotz)
Attachment #8974521 - Flags: review?(aklotz) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/04f2d2c4efe6
Fix printf format warning in TestDllInterceptorCrossProcess.cpp. r=aklotz
https://hg.mozilla.org/mozilla-central/rev/04f2d2c4efe6
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.