1460426 - Add PROCESS_MITIGATION_IMAGE_LOAD_POLICY to bootstrap process

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P1)

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Add PROCESS_MITIGATION_IMAGE_LOAD_POLICY to bootstrap process

Comment 2

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8974539 [details] [diff] [review]
Add PROCESS_MITIGATION_IMAGE_LOAD_POLICY to bootstrap process

Review of attachment 8974539 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/LauncherProcessWin.cpp
@@ +40,5 @@
> +#if !defined(PROCESS_CREATION_MITIGATION_POLICY_IMAGE_LOAD_PREFER_SYSTEM32_ALWAYS_ON)
> +# define PROCESS_CREATION_MITIGATION_POLICY_IMAGE_LOAD_PREFER_SYSTEM32_ALWAYS_ON (0x00000001ui64 << 60)
> +#endif // !defined(PROCESS_CREATION_MITIGATION_POLICY_IMAGE_LOAD_PREFER_SYSTEM32_ALWAYS_ON)
> +
> +#if (_WIN32_WINNT < 0x0602)

I think the configure script requires at least the Win8.1 SDK before it lets you build; are these here for like MinGW or am I missing something?

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Matt Howell [:mhowell] from comment #2)
> Comment on attachment 8974539 [details] [diff] [review]
> Add PROCESS_MITIGATION_IMAGE_LOAD_POLICY to bootstrap process
> 
> I think the configure script requires at least the Win8.1 SDK before it lets
> you build; are these here for like MinGW or am I missing something?

Yes, I think we do require a newer SDK, however I don't think we have actually bumped _WIN32_WINNT. My local build's mozilla-config.h is showing that _WIN32_WINNT is being defined as 0x0601.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

(Which I suppose makes sense in the context of the fact that we minimally support Windows 7, thus ensuring that developers don't use carelessly use unsupported APIs on that version... at least I think that's the rationale.)

Comment 5

[Molly Howell (she/her) (no longer active)]

Yeah, that makes sense to me. That's all I was wondering about, everything looks good here.

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd4a34b7568b2db6e772359d7ea3892779bad39b
Bug 1460426: Add PROCESS_MITIGATION_IMAGE_LOAD_POLICY to bootstrap process; r=mhowell

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/cd4a34b7568b