Phab bot does not create r+ for acceptance when there are still blocking reviewers

RESOLVED FIXED

Status

RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: smacleod, Assigned: dkl)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
If a reviewer accepts a revision while there are still other blocking reviewers, their acceptance will not be reflected on the attachment as an r+. If the blocking reviewer eventually accepts both users will then have a corresponding r_ created.

The r+ for the first reviewer should be created immediately.

For an example, see:
https://phabricator.services.mozilla.com/D1136#25721 (Initial reviewer acceptance)
https://phabricator.services.mozilla.com/D1136#25869 (Later blocking reviewer acceptance)
Bug 1459199 Comment 2 (r+ for both users)
(Assignee)

Comment 1

11 months ago
This is due to:
https://github.com/mozilla-bteam/bmo/blob/master/extensions/PhabBugz/lib/Feed.pm#L415

Currently the code skips adding r+ flags for a revision is set to 'needs-review' or 'changes-planned' so Phabricator does not set the status to 'accepted' until all blocking reviewers have accepted the revision.

I would need to just remove the revision status check and just record the acceptance status of each reviewer. Will create a PR with this change.

dkl
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Assignee)

Comment 2

11 months ago
Posted file github pr #574
(Assignee)

Updated

11 months ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.