1460467 - Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key)

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P3)

Description

[Mantaroh Yoshinaga[:mantaroh]]

This is follow up a bug of bug 1455462.

toolbox.zoomIn3.key is not referred in any locales. So we can remove this shortcuts.

We should remove this shortcut from the code of registration and test and locale:

* https://searchfox.org/mozilla-central/source/devtools/client/shared/zoom-keys.js#67
* https://searchfox.org/mozilla-central/source/devtools/client/framework/test/browser_keybindings_02.js#57
* https://searchfox.org/mozilla-central/source/devtools/client/shared/zoom-keys.js#67

Comment 1

[Abhinav Koppula]

Attachment: Bug 1460467 - Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key).

Review commit: https://reviewboard.mozilla.org/r/244438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244438/

Comment 2

[Abhinav Koppula]

Hi Mantaroh,
I have created a review request for this issue. Can you please review it?

Comment 3

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8976400 [details]
Bug 1460467 - Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key).

https://reviewboard.mozilla.org/r/244436/#review250918

Thanks Abhinav!

I think it looks good to me.
Then the try is green, I think that this patch can land central.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f15af5b5f56150a41c6456c65cb38e80760fac8e

Comment 4

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8976400 [details]
Bug 1460467 - Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key).

https://reviewboard.mozilla.org/r/244438/#review250934

Comment 5

[Abhinav Koppula]

Hi Mantaroh,
I see some orange failures in the above TRY, are those related to this fix?

Comment 6

[Mantaroh Yoshinaga[:mantaroh]]

Hi Abhinav,

(In reply to Abhinav Koppula from comment #5)
> Hi Mantaroh,
> I see some orange failures in the above TRY, are those related to this fix?

In fact, this try result contains the following test failure

 * OS X 10.10 opt (dt7) : devtools/client/debugger/test/mochitest/browser_dbg_variables-view-popup-09.js
 * OS X 10.10 debug (dt5) : devtools/client/debugger/test/mochitest/browser_dbg_sources-iframe-reload.js

This test failure is reported by bug 1373127 and bug 1455225, and these tests are marked as 'intermittent failure'.[1]

[1] https://wiki.mozilla.org/Sheriffing/How_To/Intermittent_bugs

I think that this patch doesn't affect this test, so I'll land it.

Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4825866736d8
Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key). r=mantaroh

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/4825866736d8