Closed Bug 1460467 Opened 2 years ago Closed 2 years ago

Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key)

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: mantaroh, Assigned: abhinav.koppula)

References

Details

Attachments

(1 file)

This is follow up a bug of bug 1455462.

toolbox.zoomIn3.key is not referred in any locales. So we can remove this shortcuts.

We should remove this shortcut from the code of registration and test and locale:

* https://searchfox.org/mozilla-central/source/devtools/client/shared/zoom-keys.js#67
* https://searchfox.org/mozilla-central/source/devtools/client/framework/test/browser_keybindings_02.js#57
* https://searchfox.org/mozilla-central/source/devtools/client/shared/zoom-keys.js#67
Priority: -- → P3
Hi Mantaroh,
I have created a review request for this issue. Can you please review it?
Comment on attachment 8976400 [details]
Bug 1460467 - Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key).

https://reviewboard.mozilla.org/r/244436/#review250918

Thanks Abhinav!

I think it looks good to me.
Then the try is green, I think that this patch can land central.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f15af5b5f56150a41c6456c65cb38e80760fac8e
Comment on attachment 8976400 [details]
Bug 1460467 - Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key).

https://reviewboard.mozilla.org/r/244438/#review250934
Attachment #8976400 - Flags: review?(mantaroh) → review+
Assignee: nobody → abhinav.koppula
Status: NEW → ASSIGNED
Hi Mantaroh,
I see some orange failures in the above TRY, are those related to this fix?
Flags: needinfo?(mantaroh)
Hi Abhinav,

(In reply to Abhinav Koppula from comment #5)
> Hi Mantaroh,
> I see some orange failures in the above TRY, are those related to this fix?

In fact, this try result contains the following test failure

 * OS X 10.10 opt (dt7) : devtools/client/debugger/test/mochitest/browser_dbg_variables-view-popup-09.js
 * OS X 10.10 debug (dt5) : devtools/client/debugger/test/mochitest/browser_dbg_sources-iframe-reload.js

This test failure is reported by bug 1373127 and bug 1455225, and these tests are marked as 'intermittent failure'.[1]

[1] https://wiki.mozilla.org/Sheriffing/How_To/Intermittent_bugs

I think that this patch doesn't affect this test, so I'll land it.

Thanks.
Flags: needinfo?(mantaroh)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4825866736d8
Remove unused zoom in shortcut key. (toolbox.zoomIn3.Key). r=mantaroh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4825866736d8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.