Closed Bug 1460475 Opened Last year Closed Last year

Updates to image_builder

Categories

(Firefox Build System :: Task Configuration, task)

3 Branch
task
Not set

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(5 files)

Let's make some updates to the image_builder Docker image so it is more modern.
Blocks: 1460470
Comment on attachment 8974596 [details]
Bug 1460475 - Port download-and-compress to Python 3;

https://reviewboard.mozilla.org/r/242952/#review249964

::: taskcluster/docker/image_builder/setup.sh:52
(Diff revision 3)
>  ]
>  EOF
>  )
>  
> +# We need to install for both Python 2 and 3 because `mach taskcluster-load-image`
> +# uses Python 2 and `download-and-compress` uses Python 3.

..but python-requests{,-unixsocket} is no longer installed..
Attachment #8974596 - Flags: review?(dustin) → review+
Comment on attachment 8975088 [details]
Bug 1460475 - Use stream_reader API;

https://reviewboard.mozilla.org/r/243430/#review249960

Same question here -- upgrading to 0.9.0 but not applying this cset would cause runtime failures, no?
Attachment #8975088 - Flags: review?(dustin) → review+
Comment on attachment 8974605 [details]
Bug 1460475 - Install zstandard 0.9.0 in mach;

https://reviewboard.mozilla.org/r/242972/#review249958

Shouldn't this be squashed with the previous commit?
Attachment #8974605 - Flags: review?(dustin) → review+
Comment on attachment 8974595 [details]
Bug 1460475 - Upgrade python-zstandard in image_builder;

https://reviewboard.mozilla.org/r/242950/#review249954
Attachment #8974595 - Flags: review?(dustin) → review+
Comment on attachment 8974594 [details]
Bug 1460475 - Install Python 3 on image_builder;

https://reviewboard.mozilla.org/r/242948/#review249956
Attachment #8974594 - Flags: review?(dustin) → review+
Comment on attachment 8975088 [details]
Bug 1460475 - Use stream_reader API;

https://reviewboard.mozilla.org/r/243430/#review249960

I don't see a problem here: 0.9 is backwards compatible and the code deleted in this patch will still work. However, this patch does depend on using zstandard 0.9. But since this patch is after the 0.9 patches, there shouldn't be an issue.
Comment on attachment 8974596 [details]
Bug 1460475 - Port download-and-compress to Python 3;

https://reviewboard.mozilla.org/r/242952/#review249964

> ..but python-requests{,-unixsocket} is no longer installed..

I don't think we use these packages as part of `mach` and in CI? But I can certainly re-add them to the Docker image: that's not a problem. Worst case is it is a cargo cult.
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f093c57bcc02
Install Python 3 on image_builder; r=dustin
https://hg.mozilla.org/integration/autoland/rev/358d587a6bd9
Upgrade python-zstandard in image_builder; r=dustin
https://hg.mozilla.org/integration/autoland/rev/dce97dea67c5
Install zstandard 0.9.0 in mach; r=dustin
https://hg.mozilla.org/integration/autoland/rev/359dd8da6ef8
Use stream_reader API; r=dustin
https://hg.mozilla.org/integration/autoland/rev/64ef3fab796d
Port download-and-compress to Python 3; r=dustin
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.