1460515 - Reuse more image keys at WebRenderImageData::UpdateImageKey()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Sotaro Ikeda [:sotaro]]

We could reuse more external image keys at WebRenderImageData::UpdateImageKey().

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reuse more image keys at WebRenderImageData::UpdateImageKey()

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reuse more image keys at WebRenderImageData::UpdateImageKey()

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecc06a54dd7908fd74137eb4ba7181d2f5d5f0ec

Comment 4

[Sotaro Ikeda [:sotaro]]

Hmm, there is a case that attachment 8974632 [details] [diff] [review] did not work well. "update image key" was requested to non-exisitng image key.

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reuse more image keys at WebRenderImageData::UpdateImageKey()

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reuse more image keys at WebRenderImageData::UpdateImageKey()

Rebased.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reuse more image keys at WebRenderImageData::UpdateImageKey()

Update nits.

Comment 8

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Reuse more image keys at WebRenderImageData::UpdateImageKey()

Comment 9

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0de9c5d807a083cd2e6f5dd5075799388db739a8&selectedJob=187527873

Comment 10

[Nicolas Silva [:nical]]

Comment on attachment 8991192 [details] [diff] [review]
patch - Reuse more image keys at WebRenderImageData::UpdateImageKey()

Review of attachment 8991192 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderUserData.cpp
@@ -155,5 @@
>      return mKey;
>    }
>  
> -  // Delete old key, we are generating a new key.
> -  // TODO(nical): noooo... we need to reuse image keys.

Thanks! :)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9126823d0e9c
Reuse more image keys at WebRenderImageData::UpdateImageKey() r=nical

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9126823d0e9c