1460530 - JSTerm autocompletion should reveal getters

Status: RESOLVED DUPLICATE of bug 1499289

(DevTools :: Console, defect, P2)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

JSTerm autocompletion should also offer getters for objects.

Let's see the following example:

Code on the page:

var customer = {
  get age() { return 40; },
  get name() { return "John"; },
  address: "Hawaii",
}

var store = {
  getCustomer() { return person; }
}

Expression in JSTerm:

`window.store.getPerson().`

The autocompletion should show:

* address
* age 
* name
* (etc. like standard object methods & props)


The actual result value of the expression/getter can be previewed using eager evaluation feature (see bug 1460518)

So e.g. when the user selects `name` getter offered by the autocompletion popup
(but doesn't press the enter yet), the instant result preview should show `John`.

Honza

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Fixed version of the example from comment #0

var customer = {
  get age() { return 40; },
  get name() { return "John"; },
  address: "Hawaii",
}

var store = {
  get customer() { return customer; },
  getCustomer() { return customer; },
}

Expression in JSTerm:
`window.store.getCustomer().`
or 
`window.store.customer.`

Should show:

* address
* age 
* name
* (etc. like standard object methods & props

Honza

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Honza, how is this different from https://bugzilla.mozilla.org/show_bug.cgi?id=1460530 ? Do we want to be able to automatically execute side-effects free getters?

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Nicolas Chevobbe from comment #2)
> Honza, how is this different from
> https://bugzilla.mozilla.org/show_bug.cgi?id=1460530 ? Do we want to be able
> to automatically execute side-effects free getters?
Sorry for the delay!

Your link points back to this bug, is that a copy-paste typo?

Honza

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Duh

I was talking about Bug 1499289 :)

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Yep, you are right, marking as duplicate.

Honza