Closed Bug 1460589 Opened 2 years ago Closed 2 years ago
TRR: add telemetry probe for TRR vs Native success/failure rate
2.53 KB, patch
|Details | Diff | Splinter Review|
2.21 KB, text/plain
No description provided.
How about this approach? It only adds a value if both native *and* TRR were used, but it stores all 4 different result combos.
Attachment #8974699 - Flags: review?(mcmanus)
Comment on attachment 8974699 [details] [diff] [review] 0001-TRR-add-DNS-vs-TRR-success-fail-telemetry-counter-r-.patch Review of attachment 8974699 [details] [diff] [review]: ----------------------------------------------------------------- obv need data review too thanks
Attachment #8974699 - Flags: review?(mcmanus) → review+
Comment on attachment 8974718 [details] Request for data collection review: DNS_TRR_COMPARE 1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate? Yes, Histograms.json. 2) Is there a control mechanism that allows the user to turn the data collection on and off? Yes, telemetry setting. 3) If the request is for permanent data collection, is there someone who will monitor the data over time?** Yes, Daniel Stenberg. 4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under? ** Category 1. 5) Is the data collection request for default-on or default-off? Default off on release. 6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)? No. 7) Is the data collection covered by the existing Firefox privacy notice? Yes. 8) Does there need to be a check-in in the future to determine whether to renew the data? No, permanent.
Attachment #8974718 - Flags: review?(francois) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/35a563bca099 Add DNS vs TRR success/fail telemetry counter. r=mcmanus
You need to log in before you can comment on or make changes to this bug.