logic error in nsEventListenerManager.cpp

VERIFIED FIXED

Status

()

Core
Layout
P3
normal
VERIFIED FIXED
18 years ago
18 years ago

People

(Reporter: Colin Blake, Assigned: joki (gone))

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

18 years ago
In layout/events/src/nsEventListenerManager.cpp is the following
code snippet:

                switch(aEvent->message) {
                  case NS_MENU_CREATE:
                    if (ls->mSubType & NS_EVENT_BITS_MENU_CREATE) {
                      correctSubType = PR_TRUE;
                    }

My compiler grumbles because the statement "correctSubType = PR_TRUE" can
never be executed (because NS_EVENT_BITS_MENU_CREATE is zero).

Something is wrong here!!

Colin.

Updated

18 years ago
Assignee: troy → joki
(Assignee)

Comment 1

18 years ago
I checked this is with some fixes a little while back.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Updated

18 years ago
Status: RESOLVED → VERIFIED

Comment 2

18 years ago
Based on Tom's comments, marking this as verified fixed in the Nov 15th build.
You need to log in before you can comment on or make changes to this bug.