1460629 - All dictionaries are seen as incompatible in Firefox 62 even if the install button is active

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Victor Carciu]

Attachment: Video with the issue

Prerequisites : 
Latest Nightly (FF 62) available

Steps to reproduce:
1.Go to lang pack tools from https://addons.mozilla.org/en-US/firefox/language-tools/
2.Observe that the install button is active
3.Try to install any dictionary

Expected results:
Dictionaries are installed

Actual results:
"<<dict name>> could not be installed because it is not compatible with Nightly 62.0a1" message is displayed

I will attach a video with the issue.

NOTES:
Not reproducible in FF 61.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1460629: Make dictionaries compat-by-default again.

Review commit: https://reviewboard.mozilla.org/r/243106/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243106/

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8974731 [details]
Bug 1460629: Make dictionaries compat-by-default again.

https://reviewboard.mozilla.org/r/243106/#review249344

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9e0d41838a5df1219ab40dde90edb947a39c5fd7
Bug 1460629: Make dictionaries compat-by-default again. r=aswan

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9e0d41838a5d

Comment 6

[Gabriela [:gaby2300]]

I can still reproduce in today's second nightly using Windows 7 64 bit-

Comment 7

[Gabriela [:gaby2300]]

I can still reproduce in today's nightly using Windows 7 64 bit

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Gabriela [:gaby2300] from comment #7)
> I can still reproduce in today's nightly using Windows 7 64 bit

Tested with 62.0a1 (2018-05-15) (64 bit) and installing the German and Arabic dictionary, works as expected. Maybe file a new bug at this point, if you can reproduce on a clean profile and updated nightly?

Comment 9

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I think I was facing the same problem and I had to reinstall the dictionary. The whole problem is cause by dropping support for unpacked dictionary add-ons, right? I still saw unpacked dictionary in my profile and it did not worked yesterday. After I removed it yesterday and installed again from AMO, it appeared as packed .xpi in my profile and is working again.

Is there actually any code, that migrate users with unpacked dictionaries when the support is removed? Seems there is not, or is not working.

Comment 10

[Kris Maglione [:kmag]]

(In reply to Michal Stanke (Mozilla.cz) [:MikkCZ][:mstanke] (use needinfo) from comment #9)
> I think I was facing the same problem and I had to reinstall the dictionary.
> The whole problem is cause by dropping support for unpacked dictionary
> add-ons, right?

No. Unpacked dictionaries should still work. We just don't install them unpacked anymore.

I suspect the problem is that we changed dictionary handling so that they require some additional metadata in the database in order to load them, and that data isn't present for dictionaries that were already installed. Bumping the DB schema version should fix that.

Please file a bug and I'll take care of it.

Thanks.

Comment 11

[Gabriela [:gaby2300]]

(In reply to Francesco Lodolo [:flod] from comment #8)
> (In reply to Gabriela [:gaby2300] from comment #7)
> > I can still reproduce in today's nightly using Windows 7 64 bit
> 
> Tested with 62.0a1 (2018-05-15) (64 bit) and installing the German and
> Arabic dictionary, works as expected. Maybe file a new bug at this point, if
> you can reproduce on a clean profile and updated nightly?

I did so. All worked fine, so it seems it's my profile's problem, thanks :flod!

Comment 12

[Gabriela [:gaby2300]]

I fixed my issue following :mstanke's suggestion to reinstall the dictionary. I had to restart Nightly for it to work though. Thanks :mstanke!

Comment 13

[Victor Carciu]

Verified as fixed. I installed multiple dictionaries in 62 without issues.