1460635 - change ServiceWorkerInfo not to directly reference ServiceWorker binding object

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently the ServiceWorker::Inner interface is implemented by ServiceWorkerInfo and the ServiceWorkerInfo directly references the ServiceWorker binding object.  This prevents me from implementing an alternative IPC inner object that also interacts with ServiceWorkerInfo in bug 1459209.  I need to create a ServiceWorkerInfo::Listener interface so it doesn't directly reference the binding type.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Add ServiceWorkerImpl class to isolate ServiceWorkerInfo from the binding layer. r=baku

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f1bc7da0ef04a64066a770860642da606cdc58bf

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Add ServiceWorkerImpl class to isolate ServiceWorkerInfo from the binding layer. r=baku

https://treeherder.mozilla.org/#/jobs?repo=try&revision=26949ed247032635be244d3ee32a4db2856c6e86

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8974800 [details] [diff] [review]
Add ServiceWorkerImpl class to isolate ServiceWorkerInfo from the binding layer. r=baku

Andrea, this interposes an Impl class between the binding ServiceWorker and the internal ServiceWorkerInfo.  There was already the ServiceWorker::Inner abstract interface, but ServiceWorkerInfo was referencing ServiceWorker directly.

This patch adds a ServiceWorkerInfo::Listener and then adds ServiceWorkerImpl as an implementation of both interfaces.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

I relanded bug 1456986 with what I hope is a fix for its previous crashes.  Lets see if that is stable before landing this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a256429fb18c
Add ServiceWorkerImpl class to isolate ServiceWorkerInfo from the binding layer. r=baku

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a256429fb18c