Closed Bug 1460699 Opened 2 years ago Closed 2 years ago

Misleading names in GfxInfo statics

Categories

(Core :: Graphics, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

Details

Attachments

(1 file, 1 obsolete file)

22.59 KB, patch
milan
: review+
Details | Diff | Splinter Review
They are named mFoo but they are not instance members; they are class-static.
Attached patch patch (obsolete) — Splinter Review
mFeatureStatus was a little tricky because there's also a non-static GfxDriverInfo ::mFeatureStatus referenced in these files.

The others were just sed.
Assignee: nobody → dmajor
Attachment #8974803 - Flags: review?(milaninbugzilla)
Comment on attachment 8974803 [details] [diff] [review]
patch

This patch looks incomplete, I must have forgot to refresh something
Attachment #8974803 - Flags: review?(milaninbugzilla)
Attached patch patchSplinter Review
For reals this time
Attachment #8974803 - Attachment is obsolete: true
Attachment #8974844 - Flags: review?(milaninbugzilla)
Comment on attachment 8974844 [details] [diff] [review]
patch

Review of attachment 8974844 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this!
Attachment #8974844 - Flags: review?(milaninbugzilla) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d3686581459
Use an 's' rather than 'm' prefix for GfxInfo static variables. r=milan
https://hg.mozilla.org/mozilla-central/rev/5d3686581459
https://hg.mozilla.org/mozilla-central/rev/65ab54a2a403
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.