Closed Bug 1460735 Opened 5 years ago Closed 5 years ago

Remove nsIDOMDocument

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: adrian17, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

part 1. Remove use of nsIDOMDocument in JS
15.82 KB, patch
qdot
: review+
Details | Diff | Splinter Review
part 2. Remove nsIDOMDocument
11.65 KB, patch
qdot
: review+
Details | Diff | Splinter Review 
      No description provided.
Blocks: 1387169
Assignee: nobody → adrian.wielgosik
Status: NEW → ASSIGNED
Priority: -- → P3
Depends on: 1460940
Assignee: adrian.wielgosik → nobody
Status: ASSIGNED → NEW
There are some places where we have a thing which may not even be a node, and
we end up hardcoding the value of DOCUMENT_NODE there, because
"foo.nodeType == foo.DOCUMENT_NODE" will test true if foo is not a node: both
sides will be undefined.
Attachment #8980503 - Flags: review?(kyle)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED

        Attachment #8980504 -
        Flags: review?(kyle)

    
  
Blocks: 1455676

        Attachment #8980503 -
        Flags: review?(kyle) → review+

        Attachment #8980504 -
        Flags: review?(kyle) → review+

    
    

    
  
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b36aa930a8a
part 1.  Remove use of nsIDOMDocument in JS.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/35a9ad46b395
part 2.  Remove nsIDOMDocument.  r=qdot

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3b36aa930a8a
https://hg.mozilla.org/mozilla-central/rev/35a9ad46b395
Status: ASSIGNED → RESOLVED
Closed: 5 years ago

          status-firefox62:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62

          You need to log in
          before you can comment on or make changes to this bug.