Closed Bug 1460749 Opened 8 years ago Closed 7 years ago

[wpt-sync] Sync PR 10955 - Change how invalid base URLs are tested

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10955 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10955 Details from upstream follow. Domenic Denicola <d@domenic.me> wrote: > Change how invalid base URLs are tested > > Fixes #8707. Supercedes #10917, which it is based on. > > This keeps the tests inside urltestdata.json, but adds a new requirement on consumers of that file that they should also test their base URL parsing logic by reusing the data in a different way. > > It also rearranges the various cases from 90efdbecfe3c457b36c71cf3e01a72cd5301c163 under several different headings. > > /cc @GPHemsley and @TimothyGu especially to review the changes to the README to see if they're clear on how to maintain and improve coverage. Existing harnesses will _lose_ coverage from this change, since urltestdata.json no longer tests the `a`, `a/`, and `a//` base URLs directly. But if they implement the tweak suggested in the README, they will gain coverage, testing not only those URLs as bases but also lots of others already in the file.
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 7 tests and 11 subtests OK : 7 PASS : 4 FAIL : 7 Existing tests that now have a worse result (e.g. they used to PASS and now FAIL): /url/a-element-origin-xhtml.xhtml Loading data…: FAIL /url/a-element-origin.html Loading data…: FAIL /url/a-element-xhtml.xhtml Loading data…: FAIL /url/a-element.html Loading data…: FAIL /url/failure.html Loading data…: FAIL /url/url-constructor.html Loading data…: FAIL /url/url-origin.html Loading data…: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/3d0fa22f5784 [wpt PR 10955] - Change how invalid base URLs are tested, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/1af58802560d [wpt PR 10955] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/3d0fa22f5784 https://hg.mozilla.org/mozilla-central/rev/1af58802560d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.