1460751 - gloda only partially updated on tag remove

Status: UNCONFIRMED

(Thunderbird :: Search, defect)

Description

[klaus]

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180427210249

Steps to reproduce:

if tags are removed by '0' key, the message disappears from gloda search for tags.
if message tag '1' is removed by pressing '1' ('1' being the only tag), sometimes: message is removed, sometimes message is found but tag list is empty.

Result should not be inconsistent. Expected behaviour: if the last tag is removed, message should not be returned in a gloda search for tags. It should not matter whether last tag is removed by '0' key or by tag number key.

Comment 1

[klaus]

gloda search that was used:

let query = Gloda.newQuery(Gloda.NOUN_MESSAGE);
  let tagArray = MailServices.tags.getAllTags({});
  query.tags(...tagArray);

search result with label: e.g. '$label1'. search result without label: ''. But without label, the message should not be returned in a search for tagged messages. The result of search is 'somewhat' ok (no label is set).

Comment 2

[Wayne Mery (:wsmwk)]

Klaus, does this still reproduce?

Comment 3

[klaus]

I need to retry.

Nevertheless, working with tags, I discovered that in the keyword property, sometimes they are not "removed" but reduced to a " " (space).

If the tag discover code splits the keyword string on space instead of whitespace, we get "empty" tags into the array. Gloda might stumble upon that.
John verifies returned (split) tags against the taglist in his webext version. I doubt that Gloda does that in the indexer.
So the " " might cause the msg to stay in the Gloda list of tagged messages, even if no real tag is assigned, but no real tag would be returned by Gloda (speculation, did not verify in the code)

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to klaus from comment #3)

I need to retry.