1460753 - TOTAL_SCROLL_Y and PAGE_MAX_SCROLL_Y have expired

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

TOTAL_SCROLL_Y and PAGE_MAX_SCROLL_Y both expired in 58 so we're not getting any more data from these. [1]

[1] https://searchfox.org/mozilla-central/rev/3f17a234769d25fca5144ebb8abc8e1cb3c56c16/toolkit/components/telemetry/Histograms.json#12206

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Harald do we want to renew these or remove the code here?

Comment 2

[:Dominik Strohmeier [:dstrohmeier]]

Our recent discussions around performance have started to look more into user interaction with pages as a measure of quality. I suggest to renew these.

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

(In reply to :Dominik Strohmeier [:dstrohmeier] from comment #2)
> Our recent discussions around performance have started to look more into
> user interaction with pages as a measure of quality. I suggest to renew
> these.

I'm fine with it being renewed, but someone needs to file the bug and take ownership of the probe.

If not, we really should remove this probe as it instruments a code path that is hot, and currently the results aren't even being collected.

Comment 4

[:Harald Kirschner :digitarald]

Vicky, what do you think about the perf team owning that probe? The hypothesis was that these metrics would be impacted by scroll performance improvements (like webrender), but they need more testing & investment.

Comment 5

[Vicky Chin [:vchin]]

Stuart started an effort to review all the telemetry probes, is this bug a result of that effort? 
Reviewing the probes and understanding what data we want to gather to measure performance is on the list of things I'd like to discuss when Stuart is back.

Comment 6

[Ryan Hunt [:rhunt] (on leave until early May)]

(In reply to Vicky Chin [:vchin] from comment #5)
> Stuart started an effort to review all the telemetry probes, is this bug a
> result of that effort? 
> Reviewing the probes and understanding what data we want to gather to
> measure performance is on the list of things I'd like to discuss when Stuart
> is back.

Not exactly, I implemented the original probe here for Harald and just recently
noticed the probe was expired so I filed this bug.

Comment 7

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: remove-telemetry-scroll-probe.patch

As the probe is currently expired and there's no clear owner for renewing it, I'd like to remove it. It can always be added back in if desired in the future.

Let me know if there are any objections.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/999300adcd1e
Remove TelemetryScrollProbe. r=smaug

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/999300adcd1e