1460754 - in c-c, use constants from interfaces instead of hardcoding them in JS where possible

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement)

Description

[:aceman]

There are some hard-coded constants throughout c-c for which named constants exist, which could be used instead.

Comment 1

[:aceman]

Attachment: 1460754.patch

I have found some of these.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&
revision=8dd741b06783f4b3e9ebf438e29cbd1b6126a561

Comment 2

[:aceman]

Comment on attachment 8974857 [details] [diff] [review]
1460754.patch

Review of attachment 8974857 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure why I didn't request review at the submit of the patch...

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8974857 [details] [diff] [review]
1460754.patch

Review of attachment 8974857 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, something to land ;-)

::: mailnews/extensions/mdn/test/unit/test_askuser.js
@@ -1,2 @@
> -var gMessenger = Cc["@mozilla.org/messenger;1"].
> -                   createInstance(Ci.nsIMessenger);

Not used? I can't see it from the context.

Comment 4

[:aceman]

Yes it seems not used anywhere in the file.

Comment 5

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8dd741b06783f4b3e9ebf438e29cbd1b6126a561

Comment 6

[Jorg K (CEST = GMT+2)]

Looks like the "form History Control" add-on played a trick on me and pasted that comment :-(

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c56baabedc99
use constants from interfaces instead of hardcoding them where possible. r=jorgk