Closed Bug 1460781 Opened 6 years ago Closed 6 years ago

create a non debug coverage build

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Version:
3 Branch
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox62 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: rforbes, Assigned: rforbes)

References

Details

Attachments

(1 file, 3 obsolete files)

Bug 1460781 - Add non debug build coverage build to taskcluster
59 bytes, text/x-review-board-request
marco
: review+
Details 
Currently, the only linux64 coverage build we have is a debug build. This is to create a non debug build to be used for fuzzing.
Assignee: nobody → rforbes
Attachment #8974920 - Flags: review?(mcastelluccio)
Attachment #8974921 - Flags: review?(mcastelluccio)
Attachment #8974922 - Flags: review?(mcastelluccio)
Comment on attachment 8974920 [details]
Bug 1460781 - Add non debug build coverage build to taskcluster

https://reviewboard.mozilla.org/r/243302/#review249152

::: browser/config/mozconfigs/linux64/code-coverage-opt:1
(Diff revision 1)
> +. "$topsrcdir/browser/config/mozconfigs/linux64/nightly"

It would be nice to have a common `code-coverage` mozconfig with the options needed for coverage and then a `code-coverage-debug` for the debug build and a `code-coverage-opt` for the opt build which import the common one, to avoid duplication.

::: taskcluster/ci/build/linux.yml:876
(Diff revision 1)
> +    index:
> +        product: firefox
> +        job-name: linux64-ccov-opt
> +    treeherder:
> +        platform: linux64-ccov/opt
> +        symbol: B

We should probably set tier as 2, like the debug build.
Please squash the three patches together before landing.
Comment on attachment 8975982 [details]
Bug 1460781 - incorporate changes requested from review

https://reviewboard.mozilla.org/r/244196/#review250690

Don't forget to merge the patches into a single one before landing ;)

::: taskcluster/ci/build/linux.yml:876
(Diff revision 1)
>      index:
>          product: firefox
>          job-name: linux64-ccov-opt
>      treeherder:
>          platform: linux64-ccov/opt
> -        symbol: B
> +        symbol: Bo

Use `B` here, like the normal Linux opt builds.

::: testing/mozharness/configs/builds/releng_sub_linux_configs/64_code_coverage_debug.py:1
(Diff revision 1)
> +import os

Instead of removing the old file and creating a new one, you can use `hg mv` to avoid losing the history.
Attachment #8975982 - Flags: review?(mcastelluccio) → review+
Attachment #8974920 - Attachment is obsolete: true
Attachment #8974920 - Flags: review?(mcastelluccio)
Attachment #8974922 - Attachment is obsolete: true
Attachment #8974922 - Flags: review?(mcastelluccio)
Attachment #8975982 - Attachment is obsolete: true
Comment on attachment 8974921 [details]
Bug 1460781 - Add non debug build coverage build to taskcluster

https://reviewboard.mozilla.org/r/243306/#review250962

::: browser/config/mozconfigs/linux64/code-coverage-opt:1
(Diff revision 4)
> +. "$topsrcdir/browser/config/mozconfigs/linux64/nightly"

You can directly import the common `code-coverage` mozconfig here.
Attachment #8974921 - Flags: review?(mcastelluccio) → review+
Keywords: checkin-needed
Hi,

Patch can't be landed, hasn't been r+ on the latest changes. Can you please ask for a review again?
Flags: needinfo?(rforbes)
Comment on attachment 8974921 [details]
Bug 1460781 - Add non debug build coverage build to taskcluster

https://reviewboard.mozilla.org/r/243306/#review251164
Should be done now.
Flags: needinfo?(rforbes)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5c86d04f2c63
Add non debug build coverage build to taskcluster r=marco
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5c86d04f2c63
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
See Also: → 1470079
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: