Misspelled "proces" in the "layer.c"

RESOLVED FIXED in 4.22

Status

defect
RESOLVED FIXED
Last year
2 months ago

People

(Reporter: yuki, Assigned: yuki)

Tracking

other
4.22

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I've found misspelled "procesing" in a source. It should be spelled as "processing".
https://dxr.mozilla.org/mozilla/search?q=path%3Ansprpub+proces++-process+-prproces+-uxproces&redirect=false

Steps to reproduce: None.
Expected result: There is no typo.
Actual result: There is misspelled "proces".

This bug is separated from the bug 1457395.
Posted patch Fix typo (obsolete) — Splinter Review
Fix misspelled "procesing" to "processing".
Assignee: nobody → yuki
Status: NEW → ASSIGNED
Posted patch Fix typoSplinter Review
Bug 1460820: Fix misspelled "procesing" to "processing"
Attachment #8974909 - Attachment is obsolete: true
Attachment #8974910 - Flags: review?(ted)
Attachment #8974910 - Flags: review?(ted) → review+
Keywords: checkin-needed
This patched failed to apply with the following:

applying base-d3b19447fa4d
unable to find 'pr/tests/layer.c' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file pr/tests/layer.c.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh base-d3b19447fa4d


The reject file:

--- layer.c
+++ layer.c
@@ -62,17 +62,17 @@ static PRFileDesc *PushNewLayers(PRFileD
     tmp_identity = PR_GetUniqueIdentity("Dummy 1");
     layer = PR_CreateIOLayerStub(tmp_identity, PR_GetDefaultIOMethods());
     rv = PR_PushIOLayer(stack, PR_GetLayersIdentity(stack), layer);
     if (verbosity > quiet)
         PR_fprintf(logFile, "Pushed layer(0x%x) onto stack(0x%x)\n", layer,
                                                                                                      $
     PR_ASSERT(PR_SUCCESS == rv);

-       /* push a data procesing layer */
+       /* push a data processing layer */
     layer = PR_CreateIOLayerStub(identity, &myMethods);
     rv = PR_PushIOLayer(stack, PR_GetLayersIdentity(stack), layer);
     if (verbosity > quiet)
         PR_fprintf(logFile, "Pushed layer(0x%x) onto stack(0x%x)\n", layer,
                                                                                                      $
     PR_ASSERT(PR_SUCCESS == rv);

        /* push another dummy layer */
Flags: needinfo?(yuki)
Keywords: checkin-needed
Hmm... I've confirmed that the base revision on my local repository is 4787:f47871e2aeb1, it is same to the latest revision at https://hg.mozilla.org/projects/nspr/. After I re-applied the change of the patch, I've got completely same diff. Any mistakes in the steps of creating patch? Is the repository wrong and should I refer different URL?
Flags: needinfo?(yuki) → needinfo?(rgurzau)
Ted, can you please help with the above? Thank you.
Flags: needinfo?(rgurzau) → needinfo?(ted)
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Flags: needinfo?(ted)
QA Contact: jjones
Resolution: --- → FIXED

This had been pushed to a branch only.

Now fixed on trunk, too.
https://hg.mozilla.org/projects/nspr/rev/87e3d40f7fef5b67a28d6160a731a2d3118078be

Target Milestone: --- → 4.22
You need to log in before you can comment on or make changes to this bug.