Closed
Bug 1460820
Opened 3 years ago
Closed 2 years ago
Misspelled "proces" in the "layer.c"
Categories
(NSPR :: NSPR, defect)
NSPR
NSPR
Tracking
(Not tracked)
RESOLVED
FIXED
4.22
People
(Reporter: yuki, Assigned: yuki)
Details
Attachments
(1 file, 1 obsolete file)
1.18 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
I've found misspelled "procesing" in a source. It should be spelled as "processing". https://dxr.mozilla.org/mozilla/search?q=path%3Ansprpub+proces++-process+-prproces+-uxproces&redirect=false Steps to reproduce: None. Expected result: There is no typo. Actual result: There is misspelled "proces". This bug is separated from the bug 1457395.
Assignee | ||
Comment 1•3 years ago
|
||
Fix misspelled "procesing" to "processing".
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → yuki
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•3 years ago
|
||
Bug 1460820: Fix misspelled "procesing" to "processing"
Assignee | ||
Updated•3 years ago
|
Attachment #8974909 -
Attachment is obsolete: true
Assignee | ||
Updated•3 years ago
|
Attachment #8974910 -
Flags: review?(ted)
Updated•3 years ago
|
Attachment #8974910 -
Flags: review?(ted) → review+
Assignee | ||
Updated•3 years ago
|
Keywords: checkin-needed
Comment 3•3 years ago
|
||
This patched failed to apply with the following: applying base-d3b19447fa4d unable to find 'pr/tests/layer.c' for patching (use '--prefix' to apply patch relative to the current directory) 1 out of 1 hunks FAILED -- saving rejects to file pr/tests/layer.c.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh base-d3b19447fa4d The reject file: --- layer.c +++ layer.c @@ -62,17 +62,17 @@ static PRFileDesc *PushNewLayers(PRFileD tmp_identity = PR_GetUniqueIdentity("Dummy 1"); layer = PR_CreateIOLayerStub(tmp_identity, PR_GetDefaultIOMethods()); rv = PR_PushIOLayer(stack, PR_GetLayersIdentity(stack), layer); if (verbosity > quiet) PR_fprintf(logFile, "Pushed layer(0x%x) onto stack(0x%x)\n", layer, $ PR_ASSERT(PR_SUCCESS == rv); - /* push a data procesing layer */ + /* push a data processing layer */ layer = PR_CreateIOLayerStub(identity, &myMethods); rv = PR_PushIOLayer(stack, PR_GetLayersIdentity(stack), layer); if (verbosity > quiet) PR_fprintf(logFile, "Pushed layer(0x%x) onto stack(0x%x)\n", layer, $ PR_ASSERT(PR_SUCCESS == rv); /* push another dummy layer */
Flags: needinfo?(yuki)
Keywords: checkin-needed
Assignee | ||
Comment 4•3 years ago
|
||
Hmm... I've confirmed that the base revision on my local repository is 4787:f47871e2aeb1, it is same to the latest revision at https://hg.mozilla.org/projects/nspr/. After I re-applied the change of the patch, I've got completely same diff. Any mistakes in the steps of creating patch? Is the repository wrong and should I refer different URL?
Flags: needinfo?(yuki) → needinfo?(rgurzau)
Comment 5•3 years ago
|
||
Ted, can you please help with the above? Thank you.
Flags: needinfo?(rgurzau) → needinfo?(ted)
Comment 6•2 years ago
|
||
https://hg.mozilla.org/projects/nspr/rev/fee3785aed00c5056946df0c70f04b53eb0b4077 Bug 1460820 - Fix typo r=ted
Updated•2 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(ted)
QA Contact: jjones
Resolution: --- → FIXED
Comment 7•2 years ago
|
||
This had been pushed to a branch only.
Now fixed on trunk, too.
https://hg.mozilla.org/projects/nspr/rev/87e3d40f7fef5b67a28d6160a731a2d3118078be
Target Milestone: --- → 4.22
You need to log in
before you can comment on or make changes to this bug.
Description
•