1460848 - if a node is selected, clicking the "reveal" link again will not redirect the user to the already selected node

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Bodea Daniel [:danibodea]]

STR:
1. Reach this page: https://www.polymer-project.org/2.0/start/quick-tour
2. Open Developer Tools / Inspector tab.
3. Right-click on the body and click "Expand all".
4. Scroll the HTML code to <slot id="slot"></slot>
5. Click on the "reveal" link displayed while hovering over the <label> tag.
6. Notice that the inspector tab is auto-scrolled so the corresponding node and the node is selected/highlighted.
7. Scroll back up to the <slot id="slot"></slot>
8. Click on the reveal link displayed while hovering over the <label> tag.
9. Notice that the code is NOT auto-scrolled to the (already) selected node.
Expected: The inspector should be auto-scrolled to the (already selected) node.

Comment 2

[Julian Descottes [:jdescottes]]

Sorry but I don't think this is a duplicate. This bug means that clicking reveal on the slotted version of an "already selected" node doesn't scroll the markup view. But the node is still correctly selected. The other bug is a selection issue, not a scrolling issue.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1460848 - Always scroll to container element when clicking on reveal;

Review commit: https://reviewboard.mozilla.org/r/252778/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252778/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8987539 [details]
Bug 1460848 - Always scroll to container element when clicking on reveal;

https://reviewboard.mozilla.org/r/252778/#review259290

Makes sense

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8987539 [details]
Bug 1460848 - Always scroll to container element when clicking on reveal;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252778/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ed0176b3adac
Always scroll to container element when clicking on reveal;r=bgrins

Comment 7

[Eliza Balazs [:ebalazs_]]

Backed out changeset ed0176b3adac (bug 1460848) for ES lint failure in builds/worker/checkouts/gecko/devtools/client/inspector/markup/views/slotted-node-container.js on a CLOSED TREE

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ed0176b3adac9dedc614993e464abf8d42f5534f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=185100296

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185100296&repo=autoland&lineNumber=267

Backout: https://hg.mozilla.org/integration/autoland/rev/da340330e931fe0f604fdca2513e0f60ba125675

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8987539 [details]
Bug 1460848 - Always scroll to container element when clicking on reveal;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/252778/diff/2-3/

Comment 9

[Julian Descottes [:jdescottes]]

Sorry about that, fixed the eslint failure in the latest patch.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79aabc0f2db2
Always scroll to container element when clicking on reveal;r=bgrins

Comment 11

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/79aabc0f2db2

Comment 12

[Bodea Daniel [:danibodea]]

This issue is verified in Nightly v63.0a1 on Windows 10, Ubuntu 16.04 and Mac OS X 10.12.6.

Comment 13

[Pascal Chevrel:pascalc]

Hi Julian, is there a benefit in having this patch uplifted to 62 beta or can I change the tracking flag for Firefox 62 from affected to wontfix?

Thanks

Comment 14

[Julian Descottes [:jdescottes]]

Thanks Pascal, no need to uplift this, webcomponents will only be enabled starting with 63. I updated the tracking flag for Firefox 62 accordingly.

Comment 15

[Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA]

I have reproduced this issue using Firefox 62.0a1 (2018.05.01) on Windows 10 x64.
I can confirm this issue is fixed, I verified using Firefox 63.0b3 on Ubuntu 16.04 x64, Windows  10 x64 and Mac OS X 10.13.