Closed
Bug 1460848
Opened 6 years ago
Closed 6 years ago
if a node is selected, clicking the "reveal" link again will not redirect the user to the already selected node
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(firefox62 wontfix, firefox63 verified)
VERIFIED
FIXED
Firefox 63
People
(Reporter: danibodea, Assigned: jdescottes)
References
Details
Attachments
(1 file)
STR: 1. Reach this page: https://www.polymer-project.org/2.0/start/quick-tour 2. Open Developer Tools / Inspector tab. 3. Right-click on the body and click "Expand all". 4. Scroll the HTML code to <slot id="slot"></slot> 5. Click on the "reveal" link displayed while hovering over the <label> tag. 6. Notice that the inspector tab is auto-scrolled so the corresponding node and the node is selected/highlighted. 7. Scroll back up to the <slot id="slot"></slot> 8. Click on the reveal link displayed while hovering over the <label> tag. 9. Notice that the code is NOT auto-scrolled to the (already) selected node. Expected: The inspector should be auto-scrolled to the (already selected) node.
Updated•6 years ago
|
Depends on: devtools-webcomponents-63
Priority: -- → P3
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Comment 2•6 years ago
|
||
Sorry but I don't think this is a duplicate. This bug means that clicking reveal on the slotted version of an "already selected" node doesn't scroll the markup view. But the node is still correctly selected. The other bug is a selection issue, not a scrolling issue.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Updated•6 years ago
|
Blocks: devtools-webcomponents-63
No longer depends on: devtools-webcomponents-63
Updated•6 years ago
|
Product: Firefox → DevTools
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: REOPENED → ASSIGNED
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8987539 [details] Bug 1460848 - Always scroll to container element when clicking on reveal; https://reviewboard.mozilla.org/r/252778/#review259290 Makes sense
Attachment #8987539 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Updated•6 years ago
|
Priority: P3 → P2
Comment hidden (mozreview-request) |
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ed0176b3adac Always scroll to container element when clicking on reveal;r=bgrins
Comment 7•6 years ago
|
||
Backed out changeset ed0176b3adac (bug 1460848) for ES lint failure in builds/worker/checkouts/gecko/devtools/client/inspector/markup/views/slotted-node-container.js on a CLOSED TREE Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ed0176b3adac9dedc614993e464abf8d42f5534f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=185100296 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=185100296&repo=autoland&lineNumber=267 Backout: https://hg.mozilla.org/integration/autoland/rev/da340330e931fe0f604fdca2513e0f60ba125675
Flags: needinfo?(jdescottes)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•6 years ago
|
||
Sorry about that, fixed the eslint failure in the latest patch.
Flags: needinfo?(jdescottes)
Comment 10•6 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/79aabc0f2db2 Always scroll to container element when clicking on reveal;r=bgrins
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/79aabc0f2db2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Reporter | ||
Comment 12•6 years ago
|
||
This issue is verified in Nightly v63.0a1 on Windows 10, Ubuntu 16.04 and Mac OS X 10.12.6.
Status: RESOLVED → VERIFIED
Comment 13•6 years ago
|
||
Hi Julian, is there a benefit in having this patch uplifted to 62 beta or can I change the tracking flag for Firefox 62 from affected to wontfix? Thanks
Flags: needinfo?(jdescottes)
Assignee | ||
Comment 14•6 years ago
|
||
Thanks Pascal, no need to uplift this, webcomponents will only be enabled starting with 63. I updated the tracking flag for Firefox 62 accordingly.
Flags: needinfo?(jdescottes)
Assignee | ||
Updated•6 years ago
|
Flags: qe-verify+
Flags: needinfo?(timea.zsoldos)
Comment 15•6 years ago
|
||
I have reproduced this issue using Firefox 62.0a1 (2018.05.01) on Windows 10 x64. I can confirm this issue is fixed, I verified using Firefox 63.0b3 on Ubuntu 16.04 x64, Windows 10 x64 and Mac OS X 10.13.
Flags: qe-verify+
Flags: needinfo?(timea.zsoldos)
You need to log in
before you can comment on or make changes to this bug.
Description
•