Closed Bug 1460909 Opened 8 years ago Closed 6 years ago

Do not call insert and update functions with invalid columns for given table

Categories

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P3)

Product:
Release Engineering Graveyard
Component:
Applications: Balrog (backend)
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: asilva, Unassigned)

Details

While I was working on Bug 1303424, I got "unconsumed column names" exception. Before SqlAlchemy 0.8.0b1, that exception was a warning (http://docs.sqlalchemy.org/en/rel_0_9/changelog/changelog_08.html#change-f0476d1e752c1114226c2f7b1733e959). To not block upgrade, we remove the invalid columns before build the statements (see _insertStatement, _updateStatement in db.py). Callers should not call insert and update functions with invalid columns.
Priority: -- → P1
Whiteboard: [2018audit]
Whiteboard: [2018audit]
Priority: P1 → P3

I think this is probably not an issue now that we've upgraded to the latest SQLAlchemy?

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Product: Release Engineering → Release Engineering Graveyard
You need to log in before you can comment on or make changes to this bug.