1460977 - Load searchbar stylesheets in browser.xul instead of with XBL <resources>

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Brian Grinstead [:bgrins]]

It'll be easier to migrate to a Custom Element if there aren't XBL <stylesheet> tags, and loading the sheets directly in browser.xul fits in with how we load other sheets from browser/components (like downloads).

Since doing this would change the cascade from XBL to document sheet there's a potential for specificity bugs. Although in the end IMO it will be more simple tohave the styles at the document level since we have other searchbar rules loaded in the theme's browser.css at the document level (like in urlbar-searchbar.inc.css).

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1460977 - Load searchbar styles directly in browser.xul

This is how we load styles for other components like downloads, and
lets us remove the dependancy on XBL <resources>.

Review commit: https://reviewboard.mozilla.org/r/243498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243498/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8975135 [details]
Bug 1460977 - Load searchbar styles directly in browser.xul

I'm not seeing any Talos issues with the change, so I'd like to try and get this landed if it doesn't cause styling issues. I've tested locally on an OSX build with/without the patch through various search states and haven't found any difference between:

- empty search box
- search box with text
- autocomplete result styling
- add new search engine button (i.e. on https://developer.mozilla.org/en-US/)

Unfortunately though, I don't think this is covered by mozscreenshots, and I also could be missing a UI state / component. Anything else we should be checking on here? Also, if you have a Windows build handy would you be able to check with that? If not I can test next week.

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 8975135 [details]
Bug 1460977 - Load searchbar styles directly in browser.xul

https://reviewboard.mozilla.org/r/243498/#review249404

Looks good to me, I don't notice any differences either.  I don't have a Windows build handy at the moment.  I'm on macOS.  Could you please test on Windows and Linux before landing?

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8975135 [details]
Bug 1460977 - Load searchbar styles directly in browser.xul

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243498/diff/1-2/

Comment 5

[Brian Grinstead [:bgrins]]

Did manual testing in Windows and don't see any changes with the patch applied

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f4355e937251
Load searchbar styles directly in browser.xul r=adw

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f4355e937251