1460996 - Bootstrap process should always convert argv[0] to absolute path

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[(No longer employed by Mozilla) Aaron Klotz]

STR:

1. Install a Nightly build that includes the launcher process.
2. Open cmd.exe and navigate to the directory that you installed Nightly into.
3. Run "firefox --launcher -no-remote -P"

Expected:
The profile manager is shown.

Acutal:
An error MessageBox is shown.

This is because argv[0] is just "firefox", which we then attempt to pass into CreateProcess or ShellExecute.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Ensure argv[0] is absolute

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b170a499777a8fbde9e85587af913a7082fbb428
Bug 1460996: Ensure the bootstrap process is always working with an argv[0] containing an absolute path; r=mhowell

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b170a499777a

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

I'm not super happy with the way I did this, so I'm reopening to land a better implementation.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Ensure argv[0] is absolute (v2)

Two beefs I had with my previous implementation:

1) We'd pay the price of that statically-allocated memory buffer even for non-bootstrap instances;
2) We can get rid of all of that FS access caused by SearchPath if we just query the path for the module.

Of course, GetModuleFileName is not a sane API with respect to buffer sizing, but oh well. I don't really care if we leak a buffer that's larger than the string, since it's just for bootstrapping.

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bda39fc31e2ca63e6114812deb31dfc6a60db564

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7a6b6db92a0e95f19dd8d9ddf665981e02b6b198
Bug 1460996: Ensure the bootstrap process is always working with an argv[0] containing an absolute path (v2); r=mhowell

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7a6b6db92a0e