1461032 - Add es-MX spellchecker to the installer

Status: VERIFIED FIXED

(Mozilla Localizations :: es-MX / Spanish (Mexico), enhancement)

Description

[lasr21]

We would like to request the addition of a spellchecker component to the installer.

https://addons.mozilla.org/es/firefox/addon/spanish-mexico-dictionary/

Also, we would like to know how to update it. Is it enough to update the version on AMO or are extra steps needed?

We don't have mercurial access. 

Thanks

Comment 1

[Francesco Lodolo [:flod]]

(In reply to lasr21 from comment #0)
> We would like to request the addition of a spellchecker component to the
> installer.
> 
> https://addons.mozilla.org/es/firefox/addon/spanish-mexico-dictionary/
> 
> Also, we would like to know how to update it. Is it enough to update the
> version on AMO or are extra steps needed?

I've just replied to a similar request from Uriel Jurado via email (not sure if his nick is siclemx?), but putting the relevant info here.

The dictionary that ships in Firefox builds is unrelated to AMO, it's hosted directly in the Mercurial repository for each language. Updates are also completely independent, updating it on AMO doesn't affect the dictionary shipping in the browser.

The only limit is that the dictionary needs to have a compatible license
https://wiki.mozilla.org/L10n:Dictionaries

> MPL 2.0
> MPL 1.1/LGPL 2.1/GPL 2.0 tri-licence (the old Mozilla licence)
> Apache 2.0
> BSD or MIT-style licences
> LGPL
> Public domain

I've looked inside the add-on, and while it says "MPL 2.0" on AMO, it seems to be tri-licensed (with MPL 1.1.). Both are compatible, so we can use it.

I can land updates: simply file a bug, possibly pointing to the updated files, and I'll land them. See for example what es-CL does: https://hg.mozilla.org/l10n-central/es-CL/log/tip/extensions/spellcheck/hunspell/es-CL.dic

Note that you should keep updating the dictionary on AMO, since more people might want to install it (for example, if they're using the en-US build but want the es-MX dictionary).

I can take care of landing the dictionary, will just need someone to double check that it works as expected on a new profile with es-MX builds.

Comment 2

[siclemx]

Hi Flod. Yes is the same hehe

So, We need to commit on hg first and then file a new bug with the files modified?

Mauricio do you have access to hg? Could you helps to make the commits?

CC'ing Odin and Edgardo since they are keeping updated the dictionary.

Comment 3

[siclemx]

See related Bug 1409052 for more information.

Comment 5

[Francesco Lodolo [:flod]]

(In reply to siclemx from comment #3)
> See related Bug 1409052 for more information.

Then this makes a duplicate of bug 1461032, or the other way around. For sake of simplicity I'll dupe against this one, since I'm going to use it to land the dictionary, and it will fix bug 1409052.

(In reply to siclemx from comment #2)
> So, We need to commit on hg first and then file a new bug with the files
> modified?

I'm going to do the initial commit of the dictionary next week. 

For the updates, I would suggest to update AMO, make sure that everything works, then file a bug to update the version shipping in hg.

Mauricio used to have hg access, but I'm pretty sure it expired at this point. In case, it can be re-enabled.

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #5)
> I'm going to do the initial commit of the dictionary next week. 

On second thoughts, I've already landed it
https://hg.mozilla.org/l10n-central/es-MX/rev/5abfee1e1a8baac7066eb763def880156d0bd78f

Can someone verify in the next Nightly that the dictionary is available in a new profile?

Comment 7

[Edgardo Rios]

> Can someone verify in the next Nightly that the dictionary is available in a
> new profile?

I already took a look and the dictionary is available for Nightly in a new profile.

Questions: Once the change is done, does the dictionary will be the default for Firefox (es-MX)? Do we need to do something else for Thunderbird or SeaMonkey?

Thanks!

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Edgardo Rios from comment #7)
> Questions: Once the change is done, does the dictionary will be the default
> for Firefox (es-MX)? Do we need to do something else for Thunderbird or
> SeaMonkey?

I'm not sure, since we don't manage l10n for those projects, but since the dictionary is not in a /browser folder, I assume it will be picked up by all products (noting that TB and SM are on a different release cycle, and it might take a long time).

Comment 9

[Edgardo Rios]

(In reply to Francesco Lodolo [:flod] from comment #8)
> I'm not sure, since we don't manage l10n for those projects, but since the
> dictionary is not in a /browser folder, I assume it will be picked up by all
> products (noting that TB and SM are on a different release cycle, and it
> might take a long time).

Got it, thanks again!